Test the proxy in release mode in Docker in CI on the master branch. #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were not running the proxy tests in the release configuration. Run the proxy tests in the release configuration through Docker. Docker builds with tests in release mode are too slow to run on every pull request so release mode tests will only be run on the master branch. Signed-off-by: Brian Smith <[email protected]>
siggy
approved these changes
Feb 12, 2018
.travis.yml
Outdated
| # redundant/slow. #280 | ||
| - PROXY_SKIP_TESTS=1 bin/docker-build | ||
| # We re-run the tests here in *release* (--release) mode since the | ||
| # `test` stage only runs them in *debug* node. |
olix0r
reviewed
Feb 13, 2018
bin/_docker.sh
Outdated
| @@ -52,6 +53,22 @@ docker_build() { | |||
| echo "$repo:$tag" | |||
| } | |||
|
|
|||
| docker_build_go() { | |||
There was a problem hiding this comment.
this all seems unrelated to this change?
There was a problem hiding this comment.
this all seems unrelated to this change?
Yes, bad branch management on my part. I removed that commit.
Signed-off-by: Brian Smith <[email protected]>
briansmith
force-pushed
the
b/test-proxy-release-mode-in-docker
branch
from
12ddc87 to
39cacf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were not running the proxy tests in the release configuration.
Run the proxy tests in the release configuration through Docker.
Docker builds with tests in release mode are too slow to run on every
pull request so release mode tests will only be run on the master
branch.
Signed-off-by: Brian Smith [email protected]