-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #754 #852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be a simple fix, so looks good to me. My only ask would be a test just to make sure it works within a non-top-level query.
I added a test for this in |
I was more thinking of something like
just to make sure it works within nested queries, if possible. I'm sure it'll be the same and still work, but it's worth checking. |
OK,done. Will merge when CI passes. |
* fix 754 by passing regular expressions through let insertion and flattening stages * whitespace * whitespace * add genuinely nested query test
This PR attempts to fix #754 by adding cases that recognize regular expression matching tests in the let-insertion and flattening stages of shredding. Previously these were handled generically and failing because these stages didn't provide any cases to handle variants (which is how regular expressions are represented at runtime in the IR).
This makes simple tests using regexes inside nested queries, like the one in #754 work, but does not make regular expression handling on the database any more complete/safe than it already was.
I've added debug messages to the two new cases in case we should be doing something more with the regex expressions, so that if we run into problems there will be a debugging message that gives more of a clue what the problem is.