cinnamon-session: make sure wayland sessions get a login shell #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users expect their shell profiles to get sourced at startup, which doesn't happen with wayland sessions. This commit brings back that feature, by making the cinnamon-session wrapper script run a login shell. ref: https://gitlab.gnome.org/GNOME/gnome-session/-/commit/7e307f8ddb91db5d4051c4c792519a660ba67f35
13 tasks
mkg20001
added a commit
to mkg20001/nixpkgs
that referenced
this pull request
Dec 24, 2023
This adds the patch from linuxmint/cinnamon-session#161 to fix an issue with services.xserver.cinnamon.sessionPath not being correctly applied when using gdm + wayland and possibly other combinations
marcusramberg
pushed a commit
to marcusramberg/nixpkgs
that referenced
this pull request
Dec 30, 2023
This adds the patch from linuxmint/cinnamon-session#161 to fix an issue with services.xserver.cinnamon.sessionPath not being correctly applied when using gdm + wayland and possibly other combinations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users expect their shell profiles to get sourced at startup, which doesn't happen with wayland sessions.
This commit brings back that feature, by making the cinnamon-session wrapper script run a login shell.
ref: https://gitlab.gnome.org/GNOME/gnome-session/-/commit/7e307f8ddb91db5d4051c4c792519a660ba67f35
Edit: See the comments in NixOS/nixpkgs#276060 for background I guess, in the original issue we want to append some paths to
GI_TYPELIB_PATHin/etc/profilesbut when checkingimports.gi.GIRepository.Repository.get_search_path()in Melange we found that this does not work, the issue only seems to happen with the combination of GDM + Cinnamon Wayland so far (this GDM issue).