Unregister package before installing instead of unloading

Closes r-lib#2349
lionel- · Jun 8, 2022 · e56259b · e56259b
1 parent dd960cc
commit e56259b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -27,7 +27,7 @@ Imports:
     miniUI (>= 0.1.1.1),
     pkgbuild (>= 1.3.1),
     pkgdown (>= 2.0.2),
-    pkgload (>= 1.2.4),
+    pkgload (>= 1.2.4.9001),
     profvis (>= 0.3.7),
     rcmdcheck (>= 1.4.0),
     remotes (>= 2.4.2),
@@ -62,6 +62,8 @@ Suggests:
     spelling (>= 2.2)
 VignetteBuilder: 
     knitr
+Remotes:
+    r-lib/pkgload
 Config/Needs/website: tidyverse/tidytemplate
 Encoding: UTF-8
 Language: en-US

diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,10 @@
 # devtools (development version)
 
+* `install(reload = TRUE)` now calls `pkgload::unregister()` instead
+  of `pkload::unload()` (#2349). This allows the package to keep
+  functioning if it is still in use in the R session (e.g. through
+  event handlers).
+
 * `aspell_env_var()` does a better job of matching R CMD check behaviour,
   which is only to use `aspell`, not `hunspell` or `ispell` (#2376).
 

diff --git a/R/install.R b/R/install.R
@@ -96,7 +96,7 @@ install <-
     was_attached <- is_attached(pkg)
 
     if (reload && was_loaded) {
-      pkgload::unload(pkg$package)
+      pkgload::unregister(pkg$package)
     }
 
     pkgbuild::with_build_tools(required = FALSE,