Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live AI - remove studio output stream push #3429

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Feb 27, 2025

We've enabled opus audio which is incompatible with studio for now

@github-actions github-actions bot added go Pull requests that update Go code AI Issues and PR related to the AI-video branch. labels Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 32.17133%. Comparing base (0334dfa) to head (0dd4967).

Files with missing lines Patch % Lines
server/ai_live_video.go 0.00000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3429         +/-   ##
===================================================
+ Coverage   32.16514%   32.17133%   +0.00619%     
===================================================
  Files            147         147                 
  Lines          41032       41021         -11     
===================================================
- Hits           13198       13197          -1     
+ Misses         27058       27048         -10     
  Partials         776         776                 
Files with missing lines Coverage Δ
server/ai_live_video.go 0.00000% <0.00000%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0334dfa...0dd4967. Read the comment docs.

Files with missing lines Coverage Δ
server/ai_live_video.go 0.00000% <0.00000%> (ø)

... and 1 file with indirect coverage changes

@mjh1 mjh1 changed the title Remove studio push Live AI - remove studio output stream push Feb 27, 2025
@mjh1 mjh1 requested a review from emranemran February 27, 2025 18:02
@j0sh
Copy link
Collaborator

j0sh commented Mar 3, 2025

If I am reading this correctly it would publish to the hardcoded aiWebrtc/streamkey-out ... can we use the existing path parameter instead? that would also make dev setups a little more consistent where there usually isn't a prefix since there isn't the full k8s ingress setup. see this commit which hoists out the construction for the mediamtx output URL : 603a1bf

btw the behavior before #3396 was publish to mediamtx anyway if no output was specified, we could probably do the same here by reverting most of that change and setting the output URL from the auth webhook to the empty string. That removes all the additional bookkeeping we have now storing the additional mediamtx url, pipe handling, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Issues and PR related to the AI-video branch. go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants