-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new whip server #3432
base: master
Are you sure you want to change the base?
new whip server #3432
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3432 +/- ##
===================================================
- Coverage 32.16679% 31.61087% -0.55592%
===================================================
Files 147 150 +3
Lines 41033 41878 +845
===================================================
+ Hits 13199 13238 +39
- Misses 27058 27863 +805
- Partials 776 777 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Added the ability to disable WHIP ingest entirely by omitting the Ideally we'd have a CLI argument like |
Introduces a WHIP endpoint at
/live/video-to-video/{streamid}/whip
This strictly affects ingest only; it does not touch selection, trickle or anything beyond those.
There should also be no changes to the existing MediaMTX whip / rtmp ingest. The old ingest is safe to run alongside this and there should be no behavioral changes to that. The one modification is to tighten up request methods in the HTTP handler (adding
POST
prefixes etc) to prevent route conflicts with the new WHIP endpoints.New Configuration Options
Currently implemented directly as environment variables.
Other Changes
Added a
clog.Info
function for a slog-style logging APINot Yet Implemented
These todos are all in Linear for later follow-up.