Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HLSL] implement isinf intrinsic #70095

Closed
Tracked by #30
llvm-beanz opened this issue Oct 24, 2023 · 2 comments · Fixed by #84927
Closed
Tracked by #30

[HLSL] implement isinf intrinsic #70095

llvm-beanz opened this issue Oct 24, 2023 · 2 comments · Fixed by #84927
Assignees
@farzonl
Labels
clang:codegen IR generation bugs: mangling, exceptions, etc. clang:frontend Language frontend issues, e.g. anything involving "Sema" HLSL HLSL Language Support

Comments

@llvm-beanz
Copy link
Collaborator

Implement HLSL isinf intrinsic:

https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-isinf
@llvm-beanz llvm-beanz converted this from a draft issue Oct 24, 2023
@llvm-beanz llvm-beanz added the HLSL HLSL Language Support label Oct 24, 2023
@farzonl farzonl self-assigned this Mar 8, 2024
@farzonl farzonl moved this to Planning in HLSL Support Mar 8, 2024
farzonl added a commit to farzonl/llvm-project that referenced this issue Mar 12, 2024
@farzonl
[HLSL] implement the isinf intrinsic
03941eb 
This change implements part 1 of 2 for llvm#70095
- `hlsl_intrinsics.h - add the `isinf` api
- `Builtins.td` - add an hlsl builtin for `isinf`.
- `CGBuiltin.cpp` add the ir generation for `isinf` intrinsic.
- `SemaChecking.cpp` - add a non-math elementwise checks because this is
  a bool return.
- `IntrinsicsDirectX.td - add an `isinf` intrinsic.

DXIL.td lowering is left, but changes need to be made there before we
can support this case.
@farzonl farzonl mentioned this issue Mar 12, 2024
Merged
@farzonl farzonl moved this from Planning to Active in HLSL Support Mar 12, 2024
@farzonl farzonl linked a pull request Mar 12, 2024 that will close this issue
[HLSL] implement the isinf intrinsic #84927
Merged
farzonl added a commit to farzonl/llvm-project that referenced this issue Mar 14, 2024
@farzonl
[HLSL] implement the isinf intrinsic
b21e880 
This change implements part 1 of 2 for llvm#70095
- `hlsl_intrinsics.h - add the `isinf` api
- `Builtins.td` - add an hlsl builtin for `isinf`.
- `CGBuiltin.cpp` add the ir generation for `isinf` intrinsic.
- `SemaChecking.cpp` - add a non-math elementwise checks because this is
  a bool return.
- `IntrinsicsDirectX.td - add an `isinf` intrinsic.

DXIL.td lowering is left, but changes need to be made there before we
can support this case.
farzonl added a commit that referenced this issue Mar 14, 2024
@farzonl
[HLSL] implement the isinf intrinsic (#84927)
d192b64 
This change implements part 1 of 2 for #70095
- `hlsl_intrinsics.h` - add the `isinf` api
- `Builtins.td` - add an hlsl builtin for `isinf`.
- `CGBuiltin.cpp` add the ir generation for `isinf` intrinsic.
- `SemaChecking.cpp` - add a non-math elementwise checks because this is
a bool return.
- `IntrinsicsDirectX.td` - add an `isinf` intrinsic.

`DXIL.td` lowering is left, but changes need to be made there before we
can support this case.
@github-project-automation github-project-automation bot moved this from Active to Done in HLSL Support Mar 14, 2024
@EugeneZelenko EugeneZelenko added clang:frontend Language frontend issues, e.g. anything involving "Sema" clang:codegen IR generation bugs: mangling, exceptions, etc. labels Mar 14, 2024
@llvmbot
Copy link
Member

llvmbot commented Mar 14, 2024

@llvm/issue-subscribers-clang-frontend

Author: Chris B (llvm-beanz)

Implement HLSL `isinf` intrinsic:

https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-isinf

@llvmbot
Copy link
Member

llvmbot commented Mar 14, 2024

@llvm/issue-subscribers-clang-codegen

Author: Chris B (llvm-beanz)

Implement HLSL `isinf` intrinsic:

https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-isinf

@farzonl farzonl moved this from Done to Ready in HLSL Support Mar 15, 2024
@farzonl farzonl moved this from Ready to Done in HLSL Support Mar 15, 2024
@farzonl farzonl mentioned this issue Aug 7, 2024
Closed
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@farzonl farzonl

Labels
clang:codegen IR generation bugs: mangling, exceptions, etc. clang:frontend Language frontend issues, e.g. anything involving "Sema" HLSL HLSL Language Support
Projects
HLSL Support
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[HLSL] implement the isinf intrinsic farzonl/llvm-project
4 participants
@farzonl @EugeneZelenko @llvm-beanz @llvmbot