Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HLSL] implement WaveGetLaneIndex intrinsic #70105

Closed
Tracked by #99235
, #30
...
llvm-beanz opened this issue Oct 24, 2023 · 1 comment · Fixed by #111576
Closed
Tracked by #99235
, #30
...

[HLSL] implement WaveGetLaneIndex intrinsic #70105

llvm-beanz opened this issue Oct 24, 2023 · 1 comment · Fixed by #111576
Assignees
@inbelic
Labels
HLSL HLSL Language Support

Comments

@llvm-beanz
Copy link
Collaborator

llvm-beanz commented Oct 24, 2023 •
edited by davidcook-msft
Loading

Implement HLSL WaveGetLaneIndex intrinsic:

https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/WaveGetLaneIndex

AC:

  • The intrinsic is implemented and lowered to LLVM-IR
  • Tests are implemented to validate that the IR is generated correctly
@llvm-beanz llvm-beanz converted this from a draft issue Oct 24, 2023
@llvm-beanz llvm-beanz added the HLSL HLSL Language Support label Oct 24, 2023
@farzonl farzonl mentioned this issue Jul 16, 2024
Open
@farzonl farzonl mentioned this issue Aug 7, 2024
Closed
52 tasks
@damyanp
Copy link
Contributor

damyanp commented Oct 4, 2024

Marking re-estimate this. Since this was originally refined, we have a different approach to implementing intrinsics and the way we've been estimating intrinsics has changed quite a bit.

@inbelic inbelic self-assigned this Oct 7, 2024
@inbelic inbelic mentioned this issue Oct 8, 2024
Merged
@damyanp damyanp moved this to Active in HLSL Support Oct 9, 2024
@damyanp damyanp moved this from Active to Reviewing in HLSL Support Oct 10, 2024
inbelic added a commit that referenced this issue Oct 10, 2024
@inbelic
[HLSL][DXIL] Implement WaveGetLaneIndex Intrinsic (#111576)
d36cef0 
- add additional lowering for directx backend in CGBuiltin.cpp
    - add directx intrinsic to IntrinsicsDirectX.td
    - add semantic check of arguments in SemaHLSL.cpp
    - add mapping to DXIL op in DXIL.td

    - add testing of semantics in WaveGetLaneIndex-errors.hlsl
    - add testing of dxil lowering in WaveGetLaneIndex.ll
  
Resolves #70105
DanielCChen pushed a commit to DanielCChen/llvm-project that referenced this issue Oct 16, 2024
@inbelic @DanielCChen
[HLSL][DXIL] Implement WaveGetLaneIndex Intrinsic (llvm#111576)
31a749f 
- add additional lowering for directx backend in CGBuiltin.cpp
    - add directx intrinsic to IntrinsicsDirectX.td
    - add semantic check of arguments in SemaHLSL.cpp
    - add mapping to DXIL op in DXIL.td

    - add testing of semantics in WaveGetLaneIndex-errors.hlsl
    - add testing of dxil lowering in WaveGetLaneIndex.ll
  
Resolves llvm#70105
@damyanp damyanp removed the status in HLSL Support Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@inbelic inbelic

Labels
HLSL HLSL Language Support
Projects
HLSL Support
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[HLSL][DXIL] Implement WaveGetLaneIndex Intrinsic inbelic/llvm-project
3 participants
@damyanp @llvm-beanz @inbelic