[HLSL] Improve logic for choosing spv/dx intrinsic at CG #83882
Assignees
Labels
clang:codegen
IR generation bugs: mangling, exceptions, etc.
enhancement
Improving things as opposed to bug fixing, e.g. new or missing feature
HLSL
HLSL Language Support
Comments
sudonatalie
added
enhancement
|
@llvm/issue-subscribers-clang-codegen Author: Natalie Chouinard (sudonatalie)
Follow-up from: https://github.com//pull/82536
More target-specific intrinsics are going to be added that are effectively shared between SPIR-V and DirectX backends, so we need a better design for HLSL CodeGen than repetitive switch/if statements on the target. There are a few possible patterns discussed here: #82536 (comment). |
farzonl
added a commit
to farzonl/llvm-project
that referenced
this issue
Mar 27, 2024
This PR is part of bookkeeping for llvm#83882. It also brings the SPIRV hlsl intrinsics tests in parity with where the testing is on the DXIL backend.
farzonl
added a commit
to farzonl/llvm-project
that referenced
this issue
Mar 28, 2024
This PR is part of bookkeeping for llvm#83882. It also brings the SPIRV hlsl intrinsics tests in parity with where the testing is on the DXIL backend.
This was referenced Mar 29, 2024
farzonl
added a commit
that referenced
this issue
Apr 2, 2024
This PR is part of bookkeeping for #83882. It also brings the SPIRV hlsl intrinsic tests in parity with where the testing is on the DXIL backend.
farzonl
added a commit
that referenced
this issue
Apr 5, 2024
…lection of HLSL backends (#87171) Start of #83882 - `Builtins.td` - add the `hlsl` `all` elementwise builtin. - `CGBuiltin.cpp` - Show a use case for CGHLSLUtils via an `all` intrinsic codegen. - `CGHLSLRuntime.cpp` - move `thread_id` to use CGHLSLUtils. - `CGHLSLRuntime.h` - Create a macro to help pick the right intrinsic for the backend. - `hlsl_intrinsics.h` - Add the `all` api. - `SemaChecking.cpp` - Add `all` builtin type checking - `IntrinsicsDirectX.td` - Add the `all` `dx` intrinsic - `IntrinsicsSPIRV.td` - Add the `all` `spv` intrinsic Work still needed: - `SPIRVInstructionSelector.cpp` - Add an implementation of `OpAll` for `spv_all` intrinsic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Follow-up from: #82536
More target-specific intrinsics are going to be added that are effectively shared between SPIR-V and DirectX backends, so we need a better design for HLSL CodeGen than repetitive switch/if statements on the target. There are a few possible patterns discussed here: #82536 (comment).
The text was updated successfully, but these errors were encountered: