[llvm] Support llvm::Any across shared libraries on windows #108051

fsfod · 2024-09-10T16:22:21Z

This is part of the effort to support for enabling plugins on windows by adding better support for building llvm as a DLL. The export macros used here were added in #96630

Since shared library symbols aren't deduplicated across multiple libraries on windows like Linux we have to manually explicitly import and export Any::TypeId template instantiations for the uses of llvm::Any in the LLVM codebase to support LLVM Windows shared library builds.
This change ensures that external code, including LLVM's own tests, can use PassManager callbacks when LLVM is built as a DLL.

I also removed the only use of llvm::Any for LoopNest that only existed in debug code and there also doesn't seem to be any code creating Any<LoopNest>

llvmbot · 2024-09-10T16:22:59Z

@llvm/pr-subscribers-clang-analysis
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-llvm-ir

@llvm/pr-subscribers-llvm-transforms

Author: Thomas Fransham (fsfod)

Changes

This is part of the effort to support for enabling plugins on windows by adding better support for building llvm as a DLL. The export macros used here were added in #96630

Since shared library symbols aren't deduplicated across multiple libraries on windows like Linux we have to manually explicitly import and export Any::TypeId template instantiations for the uses of llvm::Any in the LLVM codebase to support LLVM Windows shared library builds.
This change ensures that external code, including LLVM's own tests, can use PassManager callbacks when LLVM is built as a DLL.

I also removed the only use of llvm::Any for LoopNest that only existed in debug code and there also doesn't seem to be any code creating Any<LoopNest>

Full diff: https://github.com/llvm/llvm-project/pull/108051.diff

6 Files Affected:

(modified) llvm/include/llvm/Analysis/LazyCallGraph.h (+5)
(modified) llvm/include/llvm/IR/PassInstrumentation.h (+11-1)
(modified) llvm/lib/Analysis/LazyCallGraph.cpp (+4)
(modified) llvm/lib/IR/PassInstrumentation.cpp (+6)
(modified) llvm/lib/Transforms/Scalar/LoopPassManager.cpp (-2)
(modified) llvm/unittests/IR/PassBuilderCallbacksTest.cpp (-2)

diff --git a/llvm/include/llvm/Analysis/LazyCallGraph.h b/llvm/include/llvm/Analysis/LazyCallGraph.h
index e7fd18967d9bed..55060f506c3330 100644
--- a/llvm/include/llvm/Analysis/LazyCallGraph.h
+++ b/llvm/include/llvm/Analysis/LazyCallGraph.h
@@ -34,6 +34,7 @@
 #ifndef LLVM_ANALYSIS_LAZYCALLGRAPH_H
 #define LLVM_ANALYSIS_LAZYCALLGRAPH_H
 
+#include "llvm/ADT/Any.h"
 #include "llvm/ADT/ArrayRef.h"
 #include "llvm/ADT/DenseMap.h"
 #include "llvm/ADT/PointerIntPair.h"
@@ -1308,6 +1309,10 @@ class LazyCallGraphDOTPrinterPass
   static bool isRequired() { return true; }
 };
 
+#ifdef _WIN32
+extern template struct LLVM_TEMPLATE_ABI
+    Any::TypeId<const LazyCallGraph::SCC *>;
+#endif
 } // end namespace llvm
 
 #endif // LLVM_ANALYSIS_LAZYCALLGRAPH_H
diff --git a/llvm/include/llvm/IR/PassInstrumentation.h b/llvm/include/llvm/IR/PassInstrumentation.h
index 9fcc2d5957a30c..c41c287f5f1e99 100644
--- a/llvm/include/llvm/IR/PassInstrumentation.h
+++ b/llvm/include/llvm/IR/PassInstrumentation.h
@@ -50,10 +50,11 @@
 #define LLVM_IR_PASSINSTRUMENTATION_H
 
 #include "llvm/ADT/Any.h"
+#include "llvm/ADT/DenseMap.h"
 #include "llvm/ADT/FunctionExtras.h"
 #include "llvm/ADT/SmallVector.h"
-#include "llvm/ADT/DenseMap.h"
 #include "llvm/IR/PassManager.h"
+#include "llvm/Support/Compiler.h"
 #include <type_traits>
 #include <vector>
 
@@ -61,6 +62,15 @@ namespace llvm {
 
 class PreservedAnalyses;
 class StringRef;
+class Module;
+class Loop;
+class Function;
+
+#ifdef _WIN32
+extern template struct LLVM_TEMPLATE_ABI Any::TypeId<const Module *>;
+extern template struct LLVM_TEMPLATE_ABI Any::TypeId<const Function *>;
+extern template struct LLVM_TEMPLATE_ABI Any::TypeId<const Loop *>;
+#endif
 
 /// This class manages callbacks registration, as well as provides a way for
 /// PassInstrumentation to pass control to the registered callbacks.
diff --git a/llvm/lib/Analysis/LazyCallGraph.cpp b/llvm/lib/Analysis/LazyCallGraph.cpp
index e6bf8c9cbb289f..9d74bce98122bb 100644
--- a/llvm/lib/Analysis/LazyCallGraph.cpp
+++ b/llvm/lib/Analysis/LazyCallGraph.cpp
@@ -37,6 +37,10 @@ using namespace llvm;
 
 #define DEBUG_TYPE "lcg"
 
+#ifdef _WIN32
+template struct LLVM_EXPORT_TEMPLATE Any::TypeId<const LazyCallGraph::SCC *>;
+#endif
+
 void LazyCallGraph::EdgeSequence::insertEdgeInternal(Node &TargetN,
                                                      Edge::Kind EK) {
   EdgeIndexMap.try_emplace(&TargetN, Edges.size());
diff --git a/llvm/lib/IR/PassInstrumentation.cpp b/llvm/lib/IR/PassInstrumentation.cpp
index 0c4e7698d9fa87..134990eee26988 100644
--- a/llvm/lib/IR/PassInstrumentation.cpp
+++ b/llvm/lib/IR/PassInstrumentation.cpp
@@ -17,6 +17,12 @@
 
 namespace llvm {
 
+#ifdef _WIN32
+template struct LLVM_EXPORT_TEMPLATE Any::TypeId<const Module *>;
+template struct LLVM_EXPORT_TEMPLATE Any::TypeId<const Function *>;
+template struct LLVM_EXPORT_TEMPLATE Any::TypeId<const Loop *>;
+#endif
+
 void PassInstrumentationCallbacks::addClassToPassName(StringRef ClassName,
                                                       StringRef PassName) {
   ClassToPassName.try_emplace(ClassName, PassName.str());
diff --git a/llvm/lib/Transforms/Scalar/LoopPassManager.cpp b/llvm/lib/Transforms/Scalar/LoopPassManager.cpp
index a4f2dbf9a58289..cc1921d61791a4 100644
--- a/llvm/lib/Transforms/Scalar/LoopPassManager.cpp
+++ b/llvm/lib/Transforms/Scalar/LoopPassManager.cpp
@@ -273,8 +273,6 @@ PreservedAnalyses FunctionToLoopPassAdaptor::run(Function &F,
            llvm::any_cast<const LoopNest *>(&IR));
     const Loop **LPtr = llvm::any_cast<const Loop *>(&IR);
     const Loop *L = LPtr ? *LPtr : nullptr;
-    if (!L)
-      L = &llvm::any_cast<const LoopNest *>(IR)->getOutermostLoop();
     assert(L && "Loop should be valid for printing");
 
     // Verify the loop structure and LCSSA form before visiting the loop.
diff --git a/llvm/unittests/IR/PassBuilderCallbacksTest.cpp b/llvm/unittests/IR/PassBuilderCallbacksTest.cpp
index 6230aed7b7119b..9aad6e3ca91255 100644
--- a/llvm/unittests/IR/PassBuilderCallbacksTest.cpp
+++ b/llvm/unittests/IR/PassBuilderCallbacksTest.cpp
@@ -298,8 +298,6 @@ template <> std::string getName(const Any &WrappedIR) {
     return (*F)->getName().str();
   if (const auto *const *L = llvm::any_cast<const Loop *>(&WrappedIR))
     return (*L)->getName().str();
-  if (const auto *const *L = llvm::any_cast<const LoopNest *>(&WrappedIR))
-    return (*L)->getName().str();
   if (const auto *const *C =
           llvm::any_cast<const LazyCallGraph::SCC *>(&WrappedIR))
     return (*C)->getName();

llvmbot · 2024-09-10T16:22:59Z

@llvm/pr-subscribers-llvm-analysis

Author: Thomas Fransham (fsfod)

Changes

This is part of the effort to support for enabling plugins on windows by adding better support for building llvm as a DLL. The export macros used here were added in #96630

Since shared library symbols aren't deduplicated across multiple libraries on windows like Linux we have to manually explicitly import and export Any::TypeId template instantiations for the uses of llvm::Any in the LLVM codebase to support LLVM Windows shared library builds.
This change ensures that external code, including LLVM's own tests, can use PassManager callbacks when LLVM is built as a DLL.

I also removed the only use of llvm::Any for LoopNest that only existed in debug code and there also doesn't seem to be any code creating Any<LoopNest>

Full diff: https://github.com/llvm/llvm-project/pull/108051.diff

6 Files Affected:

(modified) llvm/include/llvm/Analysis/LazyCallGraph.h (+5)
(modified) llvm/include/llvm/IR/PassInstrumentation.h (+11-1)
(modified) llvm/lib/Analysis/LazyCallGraph.cpp (+4)
(modified) llvm/lib/IR/PassInstrumentation.cpp (+6)
(modified) llvm/lib/Transforms/Scalar/LoopPassManager.cpp (-2)
(modified) llvm/unittests/IR/PassBuilderCallbacksTest.cpp (-2)

diff --git a/llvm/include/llvm/Analysis/LazyCallGraph.h b/llvm/include/llvm/Analysis/LazyCallGraph.h
index e7fd18967d9bed..55060f506c3330 100644
--- a/llvm/include/llvm/Analysis/LazyCallGraph.h
+++ b/llvm/include/llvm/Analysis/LazyCallGraph.h
@@ -34,6 +34,7 @@
 #ifndef LLVM_ANALYSIS_LAZYCALLGRAPH_H
 #define LLVM_ANALYSIS_LAZYCALLGRAPH_H
 
+#include "llvm/ADT/Any.h"
 #include "llvm/ADT/ArrayRef.h"
 #include "llvm/ADT/DenseMap.h"
 #include "llvm/ADT/PointerIntPair.h"
@@ -1308,6 +1309,10 @@ class LazyCallGraphDOTPrinterPass
   static bool isRequired() { return true; }
 };
 
+#ifdef _WIN32
+extern template struct LLVM_TEMPLATE_ABI
+    Any::TypeId<const LazyCallGraph::SCC *>;
+#endif
 } // end namespace llvm
 
 #endif // LLVM_ANALYSIS_LAZYCALLGRAPH_H
diff --git a/llvm/include/llvm/IR/PassInstrumentation.h b/llvm/include/llvm/IR/PassInstrumentation.h
index 9fcc2d5957a30c..c41c287f5f1e99 100644
--- a/llvm/include/llvm/IR/PassInstrumentation.h
+++ b/llvm/include/llvm/IR/PassInstrumentation.h
@@ -50,10 +50,11 @@
 #define LLVM_IR_PASSINSTRUMENTATION_H
 
 #include "llvm/ADT/Any.h"
+#include "llvm/ADT/DenseMap.h"
 #include "llvm/ADT/FunctionExtras.h"
 #include "llvm/ADT/SmallVector.h"
-#include "llvm/ADT/DenseMap.h"
 #include "llvm/IR/PassManager.h"
+#include "llvm/Support/Compiler.h"
 #include <type_traits>
 #include <vector>
 
@@ -61,6 +62,15 @@ namespace llvm {
 
 class PreservedAnalyses;
 class StringRef;
+class Module;
+class Loop;
+class Function;
+
+#ifdef _WIN32
+extern template struct LLVM_TEMPLATE_ABI Any::TypeId<const Module *>;
+extern template struct LLVM_TEMPLATE_ABI Any::TypeId<const Function *>;
+extern template struct LLVM_TEMPLATE_ABI Any::TypeId<const Loop *>;
+#endif
 
 /// This class manages callbacks registration, as well as provides a way for
 /// PassInstrumentation to pass control to the registered callbacks.
diff --git a/llvm/lib/Analysis/LazyCallGraph.cpp b/llvm/lib/Analysis/LazyCallGraph.cpp
index e6bf8c9cbb289f..9d74bce98122bb 100644
--- a/llvm/lib/Analysis/LazyCallGraph.cpp
+++ b/llvm/lib/Analysis/LazyCallGraph.cpp
@@ -37,6 +37,10 @@ using namespace llvm;
 
 #define DEBUG_TYPE "lcg"
 
+#ifdef _WIN32
+template struct LLVM_EXPORT_TEMPLATE Any::TypeId<const LazyCallGraph::SCC *>;
+#endif
+
 void LazyCallGraph::EdgeSequence::insertEdgeInternal(Node &TargetN,
                                                      Edge::Kind EK) {
   EdgeIndexMap.try_emplace(&TargetN, Edges.size());
diff --git a/llvm/lib/IR/PassInstrumentation.cpp b/llvm/lib/IR/PassInstrumentation.cpp
index 0c4e7698d9fa87..134990eee26988 100644
--- a/llvm/lib/IR/PassInstrumentation.cpp
+++ b/llvm/lib/IR/PassInstrumentation.cpp
@@ -17,6 +17,12 @@
 
 namespace llvm {
 
+#ifdef _WIN32
+template struct LLVM_EXPORT_TEMPLATE Any::TypeId<const Module *>;
+template struct LLVM_EXPORT_TEMPLATE Any::TypeId<const Function *>;
+template struct LLVM_EXPORT_TEMPLATE Any::TypeId<const Loop *>;
+#endif
+
 void PassInstrumentationCallbacks::addClassToPassName(StringRef ClassName,
                                                       StringRef PassName) {
   ClassToPassName.try_emplace(ClassName, PassName.str());
diff --git a/llvm/lib/Transforms/Scalar/LoopPassManager.cpp b/llvm/lib/Transforms/Scalar/LoopPassManager.cpp
index a4f2dbf9a58289..cc1921d61791a4 100644
--- a/llvm/lib/Transforms/Scalar/LoopPassManager.cpp
+++ b/llvm/lib/Transforms/Scalar/LoopPassManager.cpp
@@ -273,8 +273,6 @@ PreservedAnalyses FunctionToLoopPassAdaptor::run(Function &F,
            llvm::any_cast<const LoopNest *>(&IR));
     const Loop **LPtr = llvm::any_cast<const Loop *>(&IR);
     const Loop *L = LPtr ? *LPtr : nullptr;
-    if (!L)
-      L = &llvm::any_cast<const LoopNest *>(IR)->getOutermostLoop();
     assert(L && "Loop should be valid for printing");
 
     // Verify the loop structure and LCSSA form before visiting the loop.
diff --git a/llvm/unittests/IR/PassBuilderCallbacksTest.cpp b/llvm/unittests/IR/PassBuilderCallbacksTest.cpp
index 6230aed7b7119b..9aad6e3ca91255 100644
--- a/llvm/unittests/IR/PassBuilderCallbacksTest.cpp
+++ b/llvm/unittests/IR/PassBuilderCallbacksTest.cpp
@@ -298,8 +298,6 @@ template <> std::string getName(const Any &WrappedIR) {
     return (*F)->getName().str();
   if (const auto *const *L = llvm::any_cast<const Loop *>(&WrappedIR))
     return (*L)->getName().str();
-  if (const auto *const *L = llvm::any_cast<const LoopNest *>(&WrappedIR))
-    return (*L)->getName().str();
   if (const auto *const *C =
           llvm::any_cast<const LazyCallGraph::SCC *>(&WrappedIR))
     return (*C)->getName();

llvm/include/llvm/Analysis/LazyCallGraph.h

vgvassilev · 2024-10-09T07:55:15Z

Can we make another pass over this PR?

nikic · 2024-10-09T09:48:28Z

llvm/lib/Transforms/Scalar/LoopPassManager.cpp

@@ -273,8 +273,6 @@ PreservedAnalyses FunctionToLoopPassAdaptor::run(Function &F,
           llvm::any_cast<const LoopNest *>(&IR));
    const Loop **LPtr = llvm::any_cast<const Loop *>(&IR);
    const Loop *L = LPtr ? *LPtr : nullptr;
-    if (!L)
-      L = &llvm::any_cast<const LoopNest *>(IR)->getOutermostLoop();


There's an any_cast<const LoopNest *> in an assertion left above.

Though generally I don't get why you're removing the LoopNest support here.

I guess i missed the line above, but unless i was misunderstood layers of template template instantiation i found no code creating Any with LoopNest when i checked before.

To add some more context it looks like LoopPassManager::runSinglePass would be the path a LoopNest Any could be created but it decayed to a Loop from a overload of getLoopFromIR that takes a LoopNest and returns a Loop.

I see, so the code intentionally passes the outermost loop instead of the LoopNest to pass instrumentation. In that case these changes are fine.

github-actions · 2024-10-14T23:23:29Z

✅ With the latest revision this PR passed the C/C++ code formatter.

ymand · 2024-10-15T00:13:58Z

clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h

 #include "llvm/ADT/STLExtras.h"
 #include "llvm/ADT/STLFunctionalExtras.h"
 #include "llvm/ADT/SmallVector.h"
 #include "llvm/Support/Errc.h"
 #include "llvm/Support/Error.h"

+namespace clang {
+namespace dataflow {
+class NoopLattice;


Why is this forward declaration placed in this file, when the NoopLattice is defined in its own file? Regardless, if it does belong here, please comment to explain the intent. I'm a code owner and yet I don't understand what this is doing and how/what I should do to prevent it from breaking in the case of changes. IIUC, this change is Window-specific and seems fragile, making it all the more critical to clearly document.

Its used as type in a extern template declaration below, The extern template declaration needs to be seen by code using any_cast with NoopLattice to allow external code to use the same address for the Any: Id for NoopLattice for shared library builds on windows , but i guess it really could go in the NoopLattice header. I can make whatever changes you think would be best.

Sorry -- I was asking about the whole block, not just the forward decl. Yes, please move it the NoopLattice header. Thanks!

nikic

LLVM changes LGTM

nikic · 2024-10-15T07:46:07Z

llvm/lib/Transforms/Scalar/LoopPassManager.cpp

@@ -273,8 +273,6 @@ PreservedAnalyses FunctionToLoopPassAdaptor::run(Function &F,
           llvm::any_cast<const LoopNest *>(&IR));
    const Loop **LPtr = llvm::any_cast<const Loop *>(&IR);
    const Loop *L = LPtr ? *LPtr : nullptr;
-    if (!L)
-      L = &llvm::any_cast<const LoopNest *>(IR)->getOutermostLoop();


I see, so the code intentionally passes the outermost loop instead of the LoopNest to pass instrumentation. In that case these changes are fine.

…ted form Explicitly import and export Any::TypeId template instantiations for uses of llvm::Any in the LLVM codebase to support LLVM Windows shared library builds. This change is required to allow external code to use PassManager callbacks including LLVM's own tests for it. Remove the only use of llvm::Any for LoopNest that only existed in debug code and there was no code creating Any<LoopNest>

…latforms

vgvassilev · 2024-10-22T07:31:04Z

@ymand, is your concern resolved?

ymand · 2024-10-22T13:19:10Z

@ymand, is your concern resolved?

Sorry, it isn't -- a) we still need comments with at least minimal explanation and b) I'm not sure why the definition is now in TypeErasedDataflowAnalysis.cpp -- is this because we lack NoopAnalysis.cpp? If so, why is TypeErasedDataflowAnalysis.cpp then the right place? or, should we create a NoopAnalysis.cpp?

ymand · 2024-10-22T13:26:40Z

What are the implications/requirements for users of DataflowAnalysis? Every instance specifices it's own lattice, which is converted to/from llvm::Any. Will every lattice definition require these new declarations?

fsfod · 2024-10-22T17:37:50Z

@ymand, is your concern resolved?

Sorry, it isn't -- a) we still need comments with at least minimal explanation and b) I'm not sure why the definition is now in TypeErasedDataflowAnalysis.cpp -- is this because we lack NoopAnalysis.cpp? If so, why is TypeErasedDataflowAnalysis.cpp then the right place? or, should we create a NoopAnalysis.cpp?

Yes there was no NoopAnalysis.cpp, if you fine with me creating one just to only contain an explicit instantiation i can move it there.

fsfod · 2024-10-22T17:52:08Z

What are the implications/requirements for users of DataflowAnalysis? Every instance specifices it's own lattice, which is converted to/from llvm::Any. Will every lattice definition require these new declarations?

If you think they will be used from external from the llvm library including by tests then yes.
I wish i could just put the visibility attribute on the Any Id field its self, but windows uses two different attributes to import and export a symbol which causes issues when its used by different codebases that require it to be in a different state.

ymand · 2024-10-22T21:25:55Z

What are the implications/requirements for users of DataflowAnalysis? Every instance specifices it's own lattice, which is converted to/from llvm::Any. Will every lattice definition require these new declarations?

If you think they will be used from external from the llvm library including by tests then yes. I wish i could just put the visibility attribute on the Any Id field its self, but windows uses two different attributes to import and export a symbol which causes issues when its used by different codebases that require it to be in a different state.

I see -- that's a bit of a problem. DataflowAnalysis is an abstraction, which in its implementation uses llvm::Any. Yet, IIUC, clients (who should be separated from any implementation details of the template) are now required to insert this (complex) formulation in their code. And, this is now viral -- any abstraction which seeks to wrap DataflowAnalysis and keep the Lattice type parameter will now also need to propagate this requirement to their users. And this same problem will hold for any template which uses llvm::Any in its implementation.

At the least, this requires very clear documentation -- but even better would be if there's a way to hide this in the implementation somehow, rather than pushing it on the user. Can you think of anything that would abstract this? I'd even propose a macro, but that's not enough because of demands on the namespacing. This seems unfortunately incompatible with any sort of modularity. :(

Do you have reference to an Issue tracking this or, even better, an RFC to the clang (or llvm) community? I'd like to better understand the context to see if we (analysis owners) can think of a way to avoid this. I'll also see if we can rip llvm::Any out of our implementation to avoid this altogether.

ymand · 2024-10-23T16:36:06Z

I discussed with other code owners -- we think our best option is to remove our use of llvm::Any entirely. So, I think you can go ahead with the changes here (no need for a new NoopLattice.cpp), but please add some comments explaining what's going on (even a pointer to some explanation elsewhere woudl be fine). Meantime, I'm going to work on a PR to remove use of Any. Thanks!

fsfod · 2024-10-23T17:49:10Z

idk if this was kinda the explanation you were after or not https://discourse.llvm.org/t/supporting-llvm-build-llvm-dylib-on-windows/58891

ymand

Thanks for the discussion/explanation and the comments!

ymand · 2024-10-23T20:31:21Z

idk if this was kinda the explanation you were after or not https://discourse.llvm.org/t/supporting-llvm-build-llvm-dylib-on-windows/58891

Indeed, thank you!

) This is part of the effort to support for enabling plugins on windows by adding better support for building llvm as a DLL. The export macros used here were added in llvm#96630 Since shared library symbols aren't deduplicated across multiple libraries on windows like Linux we have to manually explicitly import and export `Any::TypeId` template instantiations for the uses of `llvm::Any` in the LLVM codebase to support LLVM Windows shared library builds. This change ensures that external code, including LLVM's own tests, can use PassManager callbacks when LLVM is built as a DLL. I also removed the only use of llvm::Any for LoopNest that only existed in debug code and there also doesn't seem to be any code creating `Any<LoopNest>`

llvmbot added llvm:ir llvm:analysis llvm:transforms labels Sep 10, 2024

compnerd reviewed Sep 10, 2024

View reviewed changes

llvm/include/llvm/Analysis/LazyCallGraph.h Outdated Show resolved Hide resolved

fsfod mentioned this pull request Sep 20, 2024

Meta issue to track changes for adding plugin and LLVM_BUILD_LLVM_DYLIB support for Windows #109483

Open

40 tasks

vgvassilev requested a review from nikic October 9, 2024 07:55

nikic reviewed Oct 9, 2024

View reviewed changes

fsfod force-pushed the exported-api/llvm-any branch from 81203df to d336c45 Compare October 14, 2024 23:20

llvmbot added clang Clang issues not falling into any other category clang:dataflow Clang Dataflow Analysis framework - https://clang.llvm.org/docs/DataFlowAnalysisIntro.html clang:analysis labels Oct 14, 2024

ymand requested changes Oct 15, 2024

View reviewed changes

nikic approved these changes Oct 15, 2024

View reviewed changes

vgvassilev requested a review from ymand October 16, 2024 05:45

fsfod added 5 commits October 22, 2024 10:30

Just enable the extern template declarations and definitions on all p…

90bdee9

…latforms

Remove assert testing for a Any<const LoopNest>

00ac0c1

Fix missing export of Any::TypeId for clang::dataflow::NoopLattice

7f3ab12

Move extern template definition for NoopLattice's Any::TypeId

662a96b

vgvassilev force-pushed the exported-api/llvm-any branch from 59e94fd to 662a96b Compare October 22, 2024 07:30

fsfod added 3 commits October 23, 2024 19:08

Add comment for Any::TypeId<clang::dataflow::NoopLattice>

b487d59

Fix formatting

455dea1

Fix the right file

80efa6a

ymand approved these changes Oct 23, 2024

View reviewed changes

vgvassilev merged commit b8fddca into llvm:main Oct 24, 2024
8 checks passed

frobtech mentioned this pull request Oct 25, 2024

p/libc fexcept t #113664

Closed

fsfod deleted the exported-api/llvm-any branch December 2, 2024 11:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[llvm] Support llvm::Any across shared libraries on windows #108051

[llvm] Support llvm::Any across shared libraries on windows #108051

fsfod commented Sep 10, 2024

llvmbot commented Sep 10, 2024 •

edited

Loading

llvmbot commented Sep 10, 2024

vgvassilev commented Oct 9, 2024

nikic Oct 9, 2024

fsfod Oct 9, 2024

fsfod Oct 10, 2024

nikic Oct 15, 2024

github-actions bot commented Oct 14, 2024 •

edited

Loading

ymand Oct 15, 2024

fsfod Oct 15, 2024

ymand Oct 15, 2024

nikic left a comment

nikic Oct 15, 2024

vgvassilev commented Oct 22, 2024

ymand commented Oct 22, 2024

ymand commented Oct 22, 2024

fsfod commented Oct 22, 2024

fsfod commented Oct 22, 2024

ymand commented Oct 22, 2024

ymand commented Oct 23, 2024

fsfod commented Oct 23, 2024

ymand left a comment

ymand commented Oct 23, 2024

[llvm] Support llvm::Any across shared libraries on windows #108051

[llvm] Support llvm::Any across shared libraries on windows #108051

Conversation

fsfod commented Sep 10, 2024

llvmbot commented Sep 10, 2024 • edited Loading

llvmbot commented Sep 10, 2024

vgvassilev commented Oct 9, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Oct 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nikic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vgvassilev commented Oct 22, 2024

ymand commented Oct 22, 2024

ymand commented Oct 22, 2024

fsfod commented Oct 22, 2024

fsfod commented Oct 22, 2024

ymand commented Oct 22, 2024

ymand commented Oct 23, 2024

fsfod commented Oct 23, 2024

ymand left a comment

Choose a reason for hiding this comment

ymand commented Oct 23, 2024

llvmbot commented Sep 10, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading