Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tile combine should union cellTypes #3284

Merged
merged 2 commits into from
Aug 17, 2020
Merged

Tile combine should union cellTypes #3284

merged 2 commits into from
Aug 17, 2020

Conversation

pomadchin
Copy link
Member

@pomadchin pomadchin commented Aug 15, 2020 •
edited
Loading

Overview

This PR fixes an inconsistent API behavior and forces all combine function to behave like ArrayTile.combine

Checklist

  • ./CHANGELOG.md updated, if necessary. Link to the issue if closed, otherwise the PR.
  • Unit tests added for bug-fix or new feature

Closes #3170

@pomadchin pomadchin self-assigned this Aug 15, 2020
@pomadchin pomadchin merged commit c4ab0d9 into locationtech:master Aug 17, 2020
@pomadchin pomadchin deleted the fix/combine-union branch August 17, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pomadchin pomadchin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CroppedTile combine op doesn't union other tile's cellType.
1 participant
@pomadchin