Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused allocation from CroppedTile #3297

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

kthompson
Copy link
Contributor

No description provided.

@pomadchin
Copy link
Member

Hi @kthompson thanks a lot for fixing that! Won't you mind to check other foreach / map functions in other classes for the same issue?

And also eclipse is unhappy with your ECA, could you please sign your commit via git commit --amend -s ?

@pomadchin
Copy link
Member

pomadchin commented Oct 21, 2020

Oh, it looks like you used another email for signing ECA, or you can sign it here with a new email: https://www.eclipse.org/legal/ECA.php

@kthompson kthompson force-pushed the patch-1 branch 2 times, most recently from f271e1f to c239b4c Compare October 21, 2020 00:10
@kthompson
Copy link
Contributor Author

I am not sure what the issue is with the ECA. I have signed it but for whatever reason it doesnt "pass". I could not find any other locations with a similar issue.

@pomadchin
Copy link
Member

pomadchin commented Oct 21, 2020

@kthompson oh I see, indeed! I checked ECA manually, looks like a bot problem.

Copy link
Member

@pomadchin pomadchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a quick fix!

@pomadchin pomadchin merged commit 59887e9 into locationtech:master Oct 21, 2020
@kthompson kthompson deleted the patch-1 branch February 19, 2021 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants