Fix MosaicRasterSource.tileToLayout behavior #3338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
force-pushed
the
fix/mosasic-rs-tiling
branch
from
dfbe2a9 to
54dcb3d
Compare
pomadchin
commented
Feb 16, 2021
raster/src/main/scala/geotrellis/raster/MosaicRasterSource.scala
Outdated
Show resolved
Hide resolved
pomadchin
commented
Feb 16, 2021
| } | ||
|
|
||
| neighborhood map { | ||
| case (x, y) => checkExtent(x, y, rs) | ||
| } | ||
| } | ||
|
|
||
| // https://github.com/locationtech/geotrellis/issues/3253 | ||
| it("MosaicRasterSource should be properly tiled to layout") { |
There was a problem hiding this comment.
The idea of the test, is to prove that the read by extent behaves the same way as the read by keys (by bounds).
pomadchin
force-pushed
the
fix/mosasic-rs-tiling
branch
2 times, most recently
from
cc4c03f to
159f682
Compare
pomadchin
force-pushed
the
fix/mosasic-rs-tiling
branch
from
159f682 to
6d956f3
Compare
echeipesh
reviewed
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
MosaicRasterSource.tileToLayoutwith more than a singleRasterSourceleads to incorrect reads.Checklist
Closes #3253