ArrayTile.{cols | rows} calls boxing fix #3441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
changed the title
pomadchin
changed the title
pomadchin
force-pushed
the
fix/boxing-regression
branch
2 times, most recently
from
fecddae to
f1c266a
Compare
…pecialized dispatch
pomadchin
force-pushed
the
fix/boxing-regression
branch
from
f1c266a to
c949a9a
Compare
3 tasks
|
Going to leave here a link to this repo, for history https://github.com/pomadchin/specialization-benchmark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Since GT 3.x we had a regression where all calls to cols / rows were boxed. This lead to regressions in
MutableArrayTile.{set / update / etc}functions. For more details see #3427, #3428, #3429 and #3432This PR clarifies Grid inheritors cols / rows function types to help with the specialized calls dispatch.
Checklist
Demo
Can be reproduced via:
$ sbt project bench; benchOnly geotrellis/raster/GridBoxingBench.scalaCloses #3427
Closes #3432