Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose AWS_REQUEST_PAYER environment variable #3479

Merged
merged 3 commits into from
Jul 27, 2022
Merged

Expose AWS_REQUEST_PAYER environment variable #3479

merged 3 commits into from
Jul 27, 2022

Conversation

pomadchin
Copy link
Member

@pomadchin pomadchin commented Jul 24, 2022 •
edited
Loading

Overview

Closes #3478

Checklist

  • ./CHANGELOG.md updated, if necessary. Link to the issue if closed, otherwise the PR.

@pomadchin pomadchin force-pushed the feature/requester-pays branch 6 times, most recently from aefe3a0 to d71ab23 Compare July 24, 2022 18:36
@pomadchin pomadchin changed the title Expose AWS S3 RequestPayer env variable Expose AWS_REQUEST_PAYER variable Jul 24, 2022
@pomadchin pomadchin force-pushed the feature/requester-pays branch from d71ab23 to de655fd Compare July 24, 2022 18:38
@pomadchin pomadchin force-pushed the feature/requester-pays branch from de655fd to 0fddb30 Compare July 24, 2022 18:38
@pomadchin pomadchin changed the title Expose AWS_REQUEST_PAYER variable Expose AWS_REQUEST_PAYER environment variable Jul 24, 2022
@pomadchin pomadchin force-pushed the feature/requester-pays branch 2 times, most recently from c68f258 to 261fe03 Compare July 24, 2022 23:11
@pomadchin pomadchin force-pushed the feature/requester-pays branch from 261fe03 to 9e1779e Compare July 24, 2022 23:17
@pomadchin pomadchin force-pushed the feature/requester-pays branch from f2ac1cd to eb4f24a Compare July 27, 2022 11:07
moradology
moradology approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@moradology moradology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and we'll need this to access Landsat on AWS now, it appears. +1

s3/src/main/scala/geotrellis/store/s3/package.scala
Comment on lines +45 to +50

Try(client.headObject(request))
.map(_ => true)
.recover { case _: NoSuchKeyException => false }
.toEither
.valueOr(throw _)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner.

@pomadchin pomadchin merged commit 4efd09c into locationtech:master Jul 27, 2022
@pomadchin pomadchin deleted the feature/requester-pays branch July 27, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moradology moradology moradology approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS S3 RequestPayer env variable
2 participants
@pomadchin @moradology