Pass baseTiff to new RasterSource on GeoTiffResampleRasterSource.reproject/convert #3485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
reviewed
Sep 28, 2022
There was a problem hiding this comment.
Thank you! A nice fix, I left a couple of style related comments only! Could you also update the CHANGELOG.md, to add a link to this PR into the file under the Changed section?
I checked your email and the ECA is good indeed, mb ECLIPSE bot is angry; smth like git commit --amend && git push origin -f fix-resample-basetiff may help; if not - I'll reach them to investigate it.
raster/src/test/scala/geotrellis/raster/geotiff/GeoTiffRasterSourceSpec.scala
Outdated
Show resolved
Hide resolved
raster/src/test/scala/geotrellis/raster/geotiff/GeoTiffRasterSourceSpec.scala
Outdated
Show resolved
Hide resolved
raster/src/main/scala/geotrellis/raster/geotiff/GeoTiffReprojectRasterSource.scala
Outdated
Show resolved
Hide resolved
raster/src/main/scala/geotrellis/raster/geotiff/GeoTiffResampleRasterSource.scala
Outdated
Show resolved
Hide resolved
kervel
force-pushed
the
fix-resample-basetiff
branch
from
aff505c to
39dfefd
Compare
pomadchin
reviewed
Sep 29, 2022
pomadchin
approved these changes
Sep 29, 2022
…ojection and convert This avoids creating a new baseTiff when reprojecting or converting a resampled geotiff raster source. Signed-off-by: Frank Dekervel <[email protected]>
kervel
force-pushed
the
fix-resample-basetiff
branch
from
39dfefd to
2670d7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Before, when calling .convert or .reproject on a resampled GeoTiffRasterSource, a new baseTiff was created from the source path. Now, we preserve the baseTiff (like all other methods already do), avoiding creating a new one (and losing settings in the process)
Checklist