TCP ignores messages without trailing \n v5.6.5

[slatemine]

I suspect this is related to issue #90 and #95 but in moving from logstash 5.4.0 to 5.6.5 we hit this issue, unless a message is newline terminated it seems to get ignored.

The udp input continued to work as before.

---

• Version: 5.6.5
• Operating System: ubuntu 16.04
• Config File (if you have sensitive info, please remove it):

input {
  tcp {
    port => "514"
    type => "syslog"
  }
  udp {
    port => "514"
    type => "syslog"
  }
}

• Steps to Reproduce:
  Toggle comment on line #msg = "%s\n"%(msg)

#!/usr/bin/env python
import json, datetime
import socket
import logging
from collections import OrderedDict
logging.basicConfig(level=logging.DEBUG)
logger = logging.getLogger(__name__)

ts = datetime.datetime.now()
time = ts.isoformat()
obj = {"another":"panda", "field": time}
evt = json.dumps(obj)
logger.info(evt)

dic = OrderedDict()
dic['Event'] = obj

msg = json.dumps(dic, sort_keys=False, ensure_ascii=True)
#msg = "%s\n"%(msg)
msg = msg.encode()
logger.info((msg,time))

socket = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
try:
    socket.connect(('localhost',514))
    socket.send(msg)
finally:
    socket.close()

[slatemine]

Codec seems to be lines, even when I try to force it to plain, I wonder it that is related.

I see this in debug every time I send a msg using the above.

[DEBUG][logstash.codecs.line     ] config LogStash::Codecs::Line/@charset = "UTF-8"
[DEBUG][logstash.codecs.line     ] config LogStash::Codecs::Line/@id = "line_b369f23e-4ff4-4656-a3a7-0515fb865645"
[DEBUG][logstash.codecs.line     ] config LogStash::Codecs::Line/@enable_metric = true
[DEBUG][logstash.codecs.line     ] config LogStash::Codecs::Line/@delimiter = "\n"

[danhermann]

This issue should be resolved as of the commit referenced above and released in v5.0.3 of the TCP input plugin.

[slatemine]

v5.0.3 confirmed to be working correctly in ES 5.6.5, but I had to update Gemfile to allow the input to advance passed v4xx.