-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(mssql): add support for running tests against ms sql server #91
test(mssql): add support for running tests against ms sql server #91
Conversation
Many thanks for your pull request! I'm really excited about this contribution. In my opinion, MSSQL Server is an excellent database engine, and I'm thrilled about the prospect of extending doctrine-spatial to support it. I'll review your code as soon as possible. I'm on vacation next week, so I'm not sure how much time I'll have to work on it, but I'll get back to you as soon as I can. |
Here's my initial feedback (though it's incomplete). The tests are failing due to a minor issue. The Additionally, the CI configuration defined in the edit: I just find this action to help you to create the services: https://github.com/marketplace/actions/mssql-suite I am grateful for your valuable pull request! Thank you so much! |
#94) * test(mssql): add support for running tests against ms sql server (#91) * Create 2017, 2019 and 2022 sqlserver in CI * Quality rules applied --------- Co-authored-by: DaveHint <[email protected]>
I'd like to start to use spatial data with doctrine in one of my projects I'm working on, but unfortunately it uses Microsoft SQL Server. It would be great if
doctrine-spatial
could support it.Therefore, I'd like to contribute a potential starting point for MSSQL support:
main
when MSSQL Server startsSqlServerPlatform
as supported platform inOrmTestCase
composer.json
Feedback is welcome