-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature
: Delete Channel
#432
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I tested the functionality, works as described :)
...ure/metis/manageconversations/ui/conversation/settings/overview/ConversationOtherSettings.kt
Show resolved
Hide resolved
...ure/metis/manageconversations/ui/conversation/settings/overview/ConversationOtherSettings.kt
Outdated
Show resolved
Hide resolved
...ure/metis/manageconversations/ui/conversation/settings/overview/ConversationOtherSettings.kt
Outdated
Show resolved
Hide resolved
...mis/native_app/feature/metis/manageconversations/settings/ConversationSettingsBaseE2eTest.kt
Outdated
Show resolved
Hide resolved
...mis/native_app/feature/metis/manageconversations/settings/ConversationSettingsBaseE2eTest.kt
Outdated
Show resolved
Hide resolved
...ture/metis/manageconversations/ui/conversation/settings/overview/ConversationSettingsBody.kt
Show resolved
Hide resolved
...ure/metis/manageconversations/ui/conversation/settings/overview/ConversationOtherSettings.kt
Show resolved
Hide resolved
...ture/metis/manageconversations/ui/conversation/settings/overview/ConversationSettingsBody.kt
Show resolved
Hide resolved
...mis/native_app/feature/metis/manageconversations/settings/ConversationSettingsBaseE2eTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change, worked as expected :)
Code lgtm, I agree with Martin regarding the points mentioned, should be good to go once the changes are made
….com/ls1intum/artemis-android into feature/communication/delete-channel
Problem Description
The delete channel functionality was previously available only on the web version of Artemis. However, there was no implementation for Android, preventing moderators from deleting channels within the mobile app.
Changes
✔️ Implemented channel deletion functionality in the Conversation Settings screen.
✔️ Added a confirmation dialog before deletion to prevent accidental removals.
✔️ Integrated API call to delete the channel, ensuring consistency with the web version.
✔️ Updated UI elements to reflect the deletion process correctly.
✔️ Implemented end-to-end tests (ChannelSettingsE2eTest) to verify the functionality.
Steps for testing
PS - While I test Test User 8 (Tutor) and Test User 11 (Editor) had weird behavior but when I compare with the other Tutor and Editors everything looked okay. Maybe their role has been changed. Also in the web app they can see the buttons but other Tutors and Editors cant.
Test Case 1 - Student/Tutor/Editor
Test Case 2 - Moderator
Confirm deletion and check:
- The channel is removed from the overview.
- The user is redirected to conversation overview.
Screenshots