Feature: Add version code to push notification registrattion
#444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eylulnc
approved these changes
Mar 5, 2025
julian-wls
approved these changes
Mar 6, 2025
FelberMartin
added
ready to merge
…tion-registrattion
FelberMartin
deleted the
feature/add-version-code-to-push-notification-registrattion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
With a recent API change, the server expects the app version to be send along the push notification registration call. See ls1intum/Artemis#10384
Changes
AppVersionandAppVersionProviderto easily access the app version in the app without having to pass it all the way from theappmoduleNormalizedAppVersionto be used in modified API call and in the force-update featureSteps for testing
See that updating the push notification settings still works as expected