Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iris: Move to new project structure #55

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Iris: Move to new project structure #55

wants to merge 27 commits into from

Conversation

Hialus
Copy link
Member

@Hialus Hialus commented Mar 11, 2025

Motivation

We want to migrate Iris to a new Python project structure with more and better tooling.

Description

  • Moved the dependencies from a simple requirements file to using poetry
  • Added more tooling than flake8 and black
    • PyLint -> Linter with different checks than flake8
    • MyPy -> Enforce static typing
    • iSort -> To keep the imports consistent
    • Bandit -> Check for common code smells and security issues
    • detect-secrets -> Prevents you from accidentally pushing secrets
    • Prettier -> Formatting some non-python files
  • Expanded the pre-commit config to include the linters and some additional smaller checks

TODOs

Note: A lot of linters are still failing
@github-actions github-actions bot removed the athena label Mar 11, 2025
Copy link
Member

@bensofficial bensofficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes, especially moving the files and formatting some files, look reasonable.

@Hialus Hialus marked this pull request as ready for review March 12, 2025 23:33
@Hialus Hialus requested review from a team as code owners March 12, 2025 23:33
@Hialus Hialus requested a review from a team March 12, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants