Assessment Initialize new component
#255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@niclasheun Kannst du noch den neuen Component im Core registrieren? |
niclasheun
requested changes
Mar 11, 2025
niclasheun
reviewed
Mar 11, 2025
|
I like this change 👍 |
Mtze
changed the title
Assessment Initialize new component
rappm
commented
Mar 12, 2025
| @@ -23,7 +23,6 @@ jobs: | |||
| matching_image_tag: ${{ needs.build-clients.outputs.matching_image_tag }} | |||
| intro_course_developer_image_tag: ${{ needs.build-clients.outputs.intro_course_developer_image_tag }} | |||
| intro_course_tutor_image_tag: ${{ needs.build-clients.outputs.intro_course_tutor_image_tag }} | |||
| assessment_image_tag: ${{ needs.build-clients.outputs.assessment_image_tag }} | |||
There was a problem hiding this comment.
Should I already include this component in prod as well? @niclasheun
Not sure, as it is def not prod. ready yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
assessment_componentmicrofrontend to the repository, along with the necessary configurations for building, deploying, and integrating it. The most important changes include modifications to GitHub workflows, the addition of new component files, and updates to configuration files.GitHub Workflows:
.github/workflows/build-and-push-clients.yml: Added configurations for building and pushing theassessment_componentDocker image. [1] [2].github/workflows/deploy-docker.yml: Included the newassessment_componentimage tag in the deployment process. [1] [2].github/workflows/dev.yml: Referenced the newassessment_componentimage tag..github/workflows/prod.yml: Referenced the newassessment_componentimage tag.New Component Files:
clients/assessment_component/Dockerfile: Added Dockerfile for building theassessment_component.clients/assessment_component/package.json: Added package.json for theassessment_component.clients/assessment_component/src: Added source files includingApp.tsx,OverviewPage.tsx,SettingsPage.tsx, and bootstrap files. [1] [2] [3] [4]Configuration Files:
clients/assessment_component/.yarnrc.yml: Configured Yarn to use node-modules linker.clients/assessment_component/eslint.config.mjs: Extended root ESLint configuration.clients/assessment_component/tailwind.config.js: Configured Tailwind CSS with shared settings.clients/assessment_component/tsconfig.json: Added TypeScript configuration for theassessment_component.Documentation:
clients/assessment_component/readme: Provided a detailed guide on how to add a new component to the repository.