Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect OS color scheme #437

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

twihno
Copy link

@twihno twihno commented Mar 1, 2025

Currently, the client UI defaults to the dark color-scheme and has the option to switch to the light variant via a button.

This isn't a good default because

  1. The user already has a preference (prefers-color-scheme) which isn't respected
  2. Automatic theme switching doesn't work (e.g. on Android/iOS/some Linux systems)
  3. The change via the button is still static and doesn't use the media query

This change updates the color change functionality to default to the browser provided values instead.

It also updates the logic of the theme toggle. If the new theme matches the preferred theme, the override is removed and the theme is set to "auto" again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant