-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Increase target/compiled SDK version to 32 #12911
Conversation
Build Tools, NDK, and Gradle are also updated. Repositories is changed from jcenter() to mavenCentral().
ok for me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not too sure about mismatching NDK versions but if you say it works..
Thank you for the merge! While it is optional, we can update the NDK version to be r25b for the minetest/minetest_android_deps repository just to be safe. |
Build Tools, NDK, and Gradle are also updated. Repositories is changed from jcenter() to mavenCentral().
Oh, I did not notice that! I have not tested it in devices older than Android 6.0.1 (API level 23, 2015) because I only have Android 6.0.1 and Android 13. Comparisons between related "block" (voxel) games on the Google Play Store:
Android API levels cheat sheet: https://apilevels.com/ |
Sure. Can you open a PR to increase our minimum api level properly? |
I suggest increasing min API to 21 at least, it reduces our testing requirements |
Build Tools, NDK, and Gradle are also updated. Repositories is changed from jcenter() to mavenCentral().
Goal of the PR
This PR increases target/compiled SDK version to 32 and also updates Build Tools, NDK, and Gradle for Android build.
How does the PR work?
jcenter()
tomavenCentral()
androidx.appcompat:appcompat
: 1.3.1 -> 1.5.1I tested before and found that the minetest/minetest_android_deps still works with this higher version. It is optional to be the same version as this PR (NDK r25b).
Does it resolve any reported issue?
Yes, this PR tries to fix failed build on GitHub Action. The error message is as below:
I am not sure whether this is the correct way to fix it, but this is good as a periodic dependencies update.
Another thing to note is that Google Play will require updates to be targeting 31+ since 1 November 2022.
Does this relate to a goal in the roadmap?
Probably, this PR tries to fix a continuous integration (CI) problem and to fulfil Google Play's requirement.
To do
This PR is Ready for Review.
How to test