Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relaxing version constraints for illuminate #399

Merged
merged 1 commit into from
May 19, 2015
Merged

Relaxing version constraints for illuminate #399

merged 1 commit into from
May 19, 2015

Conversation

mvdstam
Copy link
Contributor

@mvdstam mvdstam commented May 18, 2015

This enables minor version bumps, so Laravel 5.0, 5.1, 5.2, etc. (But not 6.x.x) can be used with this package.

Also see issue #395 😄

This enables minor version bumps, so Laravel 5.0, 5.1, 5.2, etc. (But *not* 6.x.x) can be used with this package.
lucadegasperi added a commit that referenced this pull request May 19, 2015
Relaxing version constraints for illuminate
@lucadegasperi lucadegasperi merged commit fcb127e into lucadegasperi:master May 19, 2015
@mvdstam mvdstam deleted the patch-1 branch May 19, 2015 09:50
@vinkla
Copy link
Collaborator

vinkla commented May 19, 2015

Is this really a good solution? We don't know if Laravel 5.2 will break stuff. That means all current installations updating to 5.2 will break.

@GrahamCampbell
Copy link
Contributor

Yeh, this commit is wrong.

@GrahamCampbell
Copy link
Contributor

Allowing use with all minor versions is a bad idea, as each minor laravel release is the same as a semver major release.

@mvdstam
Copy link
Contributor Author

mvdstam commented May 19, 2015

So, even Laravel 5 isn't doing proper semver? That's kinda silly. Minor version bumps shouldn't break backwards compatibility, especially with frameworks. That is kind of the whole point of minor releases.

@lucadegasperi
Copy link
Owner

@GrahamCampbell The previous version of the composer.json file should be better then?

@vinkla
Copy link
Collaborator

vinkla commented May 20, 2015

@lucadegasperi Yes.

@barryvdh
Copy link

Well, the release was already tagged so it's still a problem..
https://packagist.org/packages/lucadegasperi/oauth2-server-laravel
4.0.1 will allow all 5.x versions. So people using L5.2 and requiring 4.x of your package, will be able to get 4.0.1 instead of an error that no package is available.

When a new release is made to support 5.2 (and 5.3 and 5.4 etc) it isn't a super big problem, but not really great.
Not sure if it's easy to fix by re-tagging or something. (Which usually isn't a good idea either)

@lucadegasperi
Copy link
Owner

Tagging 4.0.2 right now

@barryvdh
Copy link

Doesn't matter, the tag remains available. Composer scans all tags to find a match, so 4.0.1 will always match, even if 4.0.2 etc don't.

@GrahamCampbell
Copy link
Contributor

Yeh, the 4.0.1 tag needs deleting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants