-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relaxing version constraints for illuminate #399
Conversation
This enables minor version bumps, so Laravel 5.0, 5.1, 5.2, etc. (But *not* 6.x.x) can be used with this package.
Relaxing version constraints for illuminate
Is this really a good solution? We don't know if Laravel 5.2 will break stuff. That means all current installations updating to 5.2 will break. |
Yeh, this commit is wrong. |
Allowing use with all minor versions is a bad idea, as each minor laravel release is the same as a semver major release. |
So, even Laravel 5 isn't doing proper semver? That's kinda silly. Minor version bumps shouldn't break backwards compatibility, especially with frameworks. That is kind of the whole point of minor releases. |
@GrahamCampbell The previous version of the composer.json file should be better then? |
@lucadegasperi Yes. |
Well, the release was already tagged so it's still a problem.. When a new release is made to support 5.2 (and 5.3 and 5.4 etc) it isn't a super big problem, but not really great. |
Tagging 4.0.2 right now |
Doesn't matter, the tag remains available. Composer scans all tags to find a match, so 4.0.1 will always match, even if 4.0.2 etc don't. |
Yeh, the 4.0.1 tag needs deleting. |
This enables minor version bumps, so Laravel 5.0, 5.1, 5.2, etc. (But not 6.x.x) can be used with this package.
Also see issue #395 😄