Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): Add sort remove icon #2875

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AllanJard
Copy link

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

A new icon for use alongside arrow-down-wide-narrow and arrow-up-narrow-wide.

I'm not 100% on the name that I've chosen for the icon...!

Icon use case

I'm the author of DataTables and I'm using Lucide icons for a new extension that shows options in the header of columns. Lucide has icons for sort-asc and sort-desc, but not one for removing the sorting from a column (which is functionality I want to have as an option). I created this icon to fill the gap and thought I'd share it back to see if you wanted to have it in this amazing icon set you've created.

This is a screenshot of my use case:

image

Second use case could see it being used to indicate no sorting on a column, rather than a removal action.

Alternative icon designs

I haven't come up with any alternatives at the moment.

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons: arrow-down-wide-narrow and arrow-up-narrow-wide.
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

icons/bars-x.svg Outdated
Comment on lines 12 to 16
<path d="m 3,20 8,-8" />
<path d="M 11,20 3,12" />
<path d="M 11,4 H 21" />
<path d="M 11,8 H 21" />
<path d="m 15,12 h 6" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optimized paths.

Suggested change
<path d="m 3,20 8,-8" />
<path d="M 11,20 3,12" />
<path d="M 11,4 H 21" />
<path d="M 11,8 H 21" />
<path d="m 15,12 h 6" />
<path d="m11 20-8-8" />
<path d="M11 4h10" />
<path d="M11 8h10" />
<path d="M15 12h6" />
<path d="m3 20 8-8" />

{
"$schema": "../icon.schema.json",
"contributors": [
"AllanJard"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should include the contributors of arrow-down-wide-narrow and arrow-up-narrow-wide.

Optimise paths
Include authors of arrow-down-wide-narrow and arrow-up-narrow-wide
@AllanJard
Copy link
Author

Many thanks for the feedback! I've added them in.

Copy link

github-actions bot commented Mar 7, 2025

Added or changed icons

icons/bars-x.svg

Preview cohesion icons/square-arrow-down.svg
icons/bars-x.svg
icons/beaker.svg
Preview stroke widths icons/bars-x.svg
icons/bars-x.svg
icons/bars-x.svg
DPI Preview (24px) icons/bars-x.svg
Icon X-rays icons/bars-x.svg
Icon Diffs icons/bars-x.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const BarsXIcon = createLucideIcon('BarsX', [
  ["path",{"d":"m11 20-8-8"}],
  ["path",{"d":"M11 4h10"}],
  ["path",{"d":"M11 8h10"}],
  ["path",{"d":"M15 12h6"}],
  ["path",{"d":"m3 20 8-8"}]
])

@ericfennis
Copy link
Member

Why not using list-x?
https://lucide.dev/icons/list-x

@AllanJard
Copy link
Author

I felt that the X in the bottom left fit with the other icons a bit more, but yep, totally understand if you close this in preference for list-x.

@ericfennis
Copy link
Member

What is your opinion about this @karsa-mistmere ?

@AllanJard
Copy link
Author

I made a few more I needed as well:

image

The top two exist, this PR adds the one I've got for "Clear sort" there. I've added the icons for "Remove from sort" and the two "Add Sort..." icons. I can add them to the PR if it is of interest. But equally if not, no worries. I'm just delighted that Lucide exists :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants