-
-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icons): Add sort remove icon #2875
base: main
Are you sure you want to change the base?
Conversation
icons/bars-x.svg
Outdated
<path d="m 3,20 8,-8" /> | ||
<path d="M 11,20 3,12" /> | ||
<path d="M 11,4 H 21" /> | ||
<path d="M 11,8 H 21" /> | ||
<path d="m 15,12 h 6" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optimized paths.
<path d="m 3,20 8,-8" /> | |
<path d="M 11,20 3,12" /> | |
<path d="M 11,4 H 21" /> | |
<path d="M 11,8 H 21" /> | |
<path d="m 15,12 h 6" /> | |
<path d="m11 20-8-8" /> | |
<path d="M11 4h10" /> | |
<path d="M11 8h10" /> | |
<path d="M15 12h6" /> | |
<path d="m3 20 8-8" /> |
{ | ||
"$schema": "../icon.schema.json", | ||
"contributors": [ | ||
"AllanJard" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should include the contributors of arrow-down-wide-narrow and arrow-up-narrow-wide.
Optimise paths Include authors of arrow-down-wide-narrow and arrow-up-narrow-wide
Many thanks for the feedback! I've added them in. |
Added or changed iconsIcons as codeWorks for: const BarsXIcon = createLucideIcon('BarsX', [
["path",{"d":"m11 20-8-8"}],
["path",{"d":"M11 4h10"}],
["path",{"d":"M11 8h10"}],
["path",{"d":"M15 12h6"}],
["path",{"d":"m3 20 8-8"}]
]) |
Why not using |
I felt that the X in the bottom left fit with the other icons a bit more, but yep, totally understand if you close this in preference for |
What is your opinion about this @karsa-mistmere ? |
I made a few more I needed as well: The top two exist, this PR adds the one I've got for "Clear sort" there. I've added the icons for "Remove from sort" and the two "Add Sort..." icons. I can add them to the PR if it is of interest. But equally if not, no worries. I'm just delighted that Lucide exists :-) |
What is the purpose of this pull request?
Description
A new icon for use alongside
arrow-down-wide-narrow
andarrow-up-narrow-wide
.I'm not 100% on the name that I've chosen for the icon...!
Icon use case
I'm the author of DataTables and I'm using Lucide icons for a new extension that shows options in the header of columns. Lucide has icons for sort-asc and sort-desc, but not one for removing the sorting from a column (which is functionality I want to have as an option). I created this icon to fill the gap and thought I'd share it back to see if you wanted to have it in this amazing icon set you've created.
This is a screenshot of my use case:
Second use case could see it being used to indicate no sorting on a column, rather than a removal action.
Alternative icon designs
I haven't come up with any alternatives at the moment.
Icon Design Checklist
Concept
Author, credits & license
arrow-down-wide-narrow
andarrow-up-narrow-wide
.Naming
icons/[iconName].json
.Design
Before Submitting