Add a criteria method to the type adapter

[matthewmcgarvey]

No connected issue

After #587, there was a still one place with a hard-coded reference to the type extension namespaces

avram/src/avram/base_query_template.cr

Lines 14 to 19 in 5f51beb

	macro generate_criteria_method(query_class, name, type)
	def \{{ name }}
	column_name = "#{table_name}.\{{ name }}"
	\{{ type }}::Lucky::Criteria(\{{ query_class }}, \{{ type }}).new(self, column_name)
	end
	end

This adds a criteria method that takes in the query and the column name and returns an instance of an Avram::Criteria for the given type.

One of the other benefits it gives us is that we don't need special handling for generic types since we are calling methods on the class instead of using it to access a namespace.

This would be a breaking change since the criteria method is completely new and custom types would need to implement it.

The rules for adding custom types would be:

• The type must have an adapter class-level method that returns a class that includes the Avram::Type module
• That class must have a criteria class-level method that returns an instance of Avram::Criteria for the type

I considered moving the criteria method onto the type we extend but I didn't want to pollute the core library types with another function.

[jwoertink]

This is probably fine, just that one part confusing me a little

[jwoertink]

I'm a little confused on why we don't need to check for Array(String) and it will know to use String.adapter 🤔

[matthewmcgarvey]

Given a type of Array(String) it will call Array(String).adapter and that method calls .adapter on the generic type of the array which in this case is String.adapter.

avram/src/avram/charms/array_extensions.cr

Lines 1 to 7 in efe1d8a

	class Array(T)
	# Proxy to the `T`'s adapter so we can call methods like
	# `Array(String).adapter.to_db(["test"])`
	def self.adapter
	T.adapter
	end
	end

[jwoertink]

ahh! boom! I missed that part.