Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mutate the query builder when calling the statement methods #715

Merged

Conversation

bnjamin
Copy link
Contributor

@bnjamin bnjamin commented Jul 31, 2021

Fixes #712

Clone the queries, so the subsequent calls to #statement and #statement_for_update returns the same result.

def select_count : Int64
table = "(#{query.statement}) AS temp"
new_query = Avram::QueryBuilder.new(table).select_count
result = database.scalar new_query.statement, args: query.args, queryable: schema_class.name

Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! Thanks for fixing this 🎉

@jwoertink jwoertink merged commit 8f6301c into luckyframework:master Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with bulk update after calling select_count
2 participants