Add adapter for validation translations #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed this PR also includes the migration order changes (sloppy me). Sorry about that. 😊 |
robacarp
reviewed
Oct 29, 2021
jwoertink
reviewed
Oct 29, 2021
jwoertink
approved these changes
Oct 31, 2021
|
Awesome! This looks great to me. I'll merge it in so we can start playing with it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to configure a custom i18n backed for validation translations, as discussed in #754. It also adds simple interpolation using format strings to create clearer error messages. For example in
validate_size_of, the error message forminused to be"is too short", and is now"must have at least %s characters".