Lucky::RequestTypeHelpers#ajax? always false

[skojin]

enable :js format in action: accepted_formats [:js]
do remote request with rjs
ajax? returns false because clients_desired_format == :js

This happen because accept_header checked before X-Requested-With

lucky/src/lucky/mime_type.cr

Lines 54 to 57 in b59d48d

	if usable_accept_header? && accept
	from_accept_header(accept)
	elsif ajax?
	:ajax

[paulcsmith]

Ohh that makes sense. Would you mind writing a PR with a spec that catches this and then put ajax? ahead of the usable_accept_header?

[skojin]

Ok,

But the question is why they are exclusive? I can make xhr request and it will be both :js and :ajax

I can't just move line just ahead of usable_accept_header, that will give page format :ajax instead of :js

I suggest remove this spec

lucky/spec/lucky/mime_type_spec.cr

Lines 27 to 30 in b59d48d

	it "returns :ajax if it is an AJAX request and no 'Accept' header is given" do
	format = determine_format("X-Requested-With": "XmlHttpRequest")
	format.should eq(:ajax)
	end

and make request_type_helpers.cr#ajax? just check XMLHttpRequest, same as rails xhr?

[paulcsmith]

@skojin You are totally right. Removing that spec and making ajax? just check the header sounds perfect. I imagine it'd still be nice to combine "accepts" and "ajax" together and your proposed approach makes that easy 👍