Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding to_param on UUID extensions #945

Merged
merged 2 commits into from
Nov 15, 2019
Merged

Adding to_param on UUID extensions #945

merged 2 commits into from
Nov 15, 2019

Conversation

russ
Copy link
Contributor

@russ russ commented Oct 11, 2019

Purpose

This allows UUID values to be used in routes.

Checklist

  • - All specs are formatted with crystal tool format spec src
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

paulcsmith
paulcsmith requested changes Oct 22, 2019
View reviewed changes
Copy link
Member

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be superfluous but just to make sure we don't accidentally delete this method or rename it, could you add a spec for this? It'd probably go in spec/charms/uuid_spec.cr

@jwoertink
Copy link
Member

I think this is fine now.

@jwoertink jwoertink merged commit 956d3ab into luckyframework:master Nov 15, 2019
@jkthorne
Copy link
Contributor

I just saw this. I think this will fix some bugs I was seeing.

Thanks !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcsmith paulcsmith paulcsmith requested changes

@jwoertink jwoertink jwoertink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@russ @jwoertink @jkthorne @paulcsmith