Use new separated lucky and avram #711
Closed
+16
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robacarp
reviewed
Dec 27, 2021
| require "lucky" | ||
| require "avram" | ||
| require "avram/lucky" |
There was a problem hiding this comment.
Could you make "avram/lucky" require the base avram library?
There was a problem hiding this comment.
It already does, but I went the more explicit route
jwoertink
added a commit
that referenced
this pull request
May 29, 2022
jwoertink
added a commit
that referenced
this pull request
Jul 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the cli to incorporate the changes of luckyframework/lucky#1620 and luckyframework/avram#772.