Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node guides for CLI v0.16 #915

Merged
merged 4 commits into from
Mar 1, 2024
Merged

Update node guides for CLI v0.16 #915

merged 4 commits into from
Mar 1, 2024

Conversation

fhildeb
Copy link
Contributor

@fhildeb fhildeb commented Feb 28, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 28, 2024 •
edited
Loading

Deployed with Cloudflare Pages ☁️ 🚀 🆗

@fhildeb fhildeb requested a review from Wolmin February 29, 2024 10:19
@fhildeb fhildeb marked this pull request as ready for review March 1, 2024 12:30
@fhildeb fhildeb requested a review from Hugoo as a code owner March 1, 2024 12:30
@fhildeb
Copy link
Contributor Author

fhildeb commented Mar 1, 2024 •
edited
Loading

@Hugoo @CJ42 LGTM, CLI and network configs have been released 👍🏻

After this is merged, we will do the announcement.

@fhildeb fhildeb changed the title Prepare node guides for CLI v0.16 Update node guides for CLI v0.16 Mar 1, 2024
Hugoo
Hugoo reviewed Mar 1, 2024
View reviewed changes
Copy link
Contributor

@Hugoo Hugoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mxmar could you double check the Clients versions please? If they are compatible.

docs/networks/advanced-guides/update-clients.md Outdated
If you updated the network configuration files but are running a Prysm client **below** Version `4.0.8`, your client may not know configuration properties that were introduced in later stages:

```text
There were some issues parsing the config from a yaml file" error="yaml: unmarshal errors:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this " at the first line? It looks off but maybe this is how the error output looks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed them- the error was copied from the terminal, but they are unnecessary here.

@fhildeb
Copy link
Contributor Author

fhildeb commented Mar 1, 2024

Client versions are directly taken from:

lukso-network/tools-lukso-cli#232

Bildschirmfoto 2024-03-01 um 18 42 04

@fhildeb fhildeb requested a review from Hugoo March 1, 2024 17:53
@Hugoo Hugoo merged commit be540c9 into main Mar 1, 2024
2 checks passed
@Hugoo Hugoo deleted the update-node-guides branch March 1, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxmar mxmar mxmar approved these changes

@CJ42 CJ42 CJ42 approved these changes

@Wolmin Wolmin Wolmin approved these changes

@Hugoo Hugoo Awaiting requested review from Hugoo

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fhildeb @Hugoo @mxmar @CJ42 @Wolmin