Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename each occurrence of LXD to Incus #3

Merged
merged 3 commits into from
Dec 17, 2023
Merged

Rename each occurrence of LXD to Incus #3

merged 3 commits into from
Dec 17, 2023

Conversation

maveonair
Copy link
Member

With this PR we rename each occurrence of LXD to Incus.

What's been done

  • README updated on how to set up the provider until it is not published in the Terraform registry
  • Updated the documentation to remove the mention of the incus configuration in the snap folder
  • All resources now have the prefix incus_ instead of lxd_
  • The documentation has been updated accordingly

stgraber
stgraber reviewed Dec 16, 2023
View reviewed changes
stgraber
stgraber reviewed Dec 16, 2023
View reviewed changes
@stgraber
Copy link
Member

Just a few small nits to fix :)

Can't say I've reviewed every line as it's mostly a search&replace type change, but I think I caught the usual small issues we've found when doing the same kind of change in Incus itself.

@maveonair maveonair force-pushed the rename-lxd-to-incus branch 2 times, most recently from 1967f45 to 22736fb Compare December 16, 2023 21:39
@maveonair maveonair requested a review from stgraber December 16, 2023 23:45
@stgraber stgraber force-pushed the rename-lxd-to-incus branch from 22736fb to 38ca5ae Compare December 17, 2023 05:50
stgraber
stgraber approved these changes Dec 17, 2023
View reviewed changes
Copy link
Member

@stgraber stgraber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did some basic commit re-titling and merged the bugfixes with the first commit, all good now.

@stgraber stgraber merged commit e3cb641 into lxc:main Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stgraber stgraber stgraber approved these changes

@adamcstephens adamcstephens Awaiting requested review from adamcstephens

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maveonair @stgraber