Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Also test on Go 1.20 #4

Merged
merged 1 commit into from
Dec 17, 2023
Merged

github: Also test on Go 1.20 #4

merged 1 commit into from
Dec 17, 2023

Conversation

stgraber
Copy link
Member

No description provided.

Signed-off-by: Stéphane Graber <[email protected]>
@adamcstephens
Copy link
Contributor

adamcstephens commented Dec 17, 2023

Almost all users will be using the pre compiled binaries from the registry. What value do you see in testing the older Go version here?

I normally agree a project should support both releases of Go, but these tests take a number of minutes each.

@stgraber
Copy link
Member Author

I see two benefits from it, one is it gives us a better view of potential Go compiler bugs by testing on more than one release. That's something that's proved itself useful for Incus in the past. The other is to support an older Go release for the few Linux distributions that would like to ship the provider as a package. Distros are quite often one major release behind so making sure we don't rely on the absolute latest features should help.

I don't really see this as adding testing time given it's done in a test matrix and so is run in parallel by Github. It certainly consumes more test runners but it's not like we pay for those ;)

Copy link
Contributor

@adamcstephens adamcstephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objection. I am curious what distros beside nixos package terraform providers. ;)

@stgraber
Copy link
Member Author

I found some hits around Gentoo derivatives at least. It's definitely not a very common thing but no real harm in supporting it either.

@stgraber stgraber merged commit f254037 into lxc:main Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants