Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version and min. Qt version #52

Merged
merged 2 commits into from
Apr 21, 2020
Merged

Bump version and min. Qt version #52

merged 2 commits into from
Apr 21, 2020

Conversation

tsujan
Copy link
Member

@tsujan tsujan commented Apr 21, 2020

We can't use Qt < 5.10 in some projects. It's better to change 5.7.1 here.

We can't use Qt < 5.10 in some projects. It's better to change 5.7.1 here.
@tsujan tsujan requested a review from luis-pereira April 21, 2020 13:13
Copy link
Member

@luis-pereira luis-pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM.
5.10 as the minimum required was already discussed and agreed.

@tsujan
Copy link
Member Author

tsujan commented Apr 21, 2020

Thanks for the quick reply.

I might need your reviews of small pre-release changes to other components too (although nothing special comes to my mind for now).

@tsujan tsujan merged commit 768fc23 into master Apr 21, 2020
@tsujan tsujan deleted the prepare_for_release branch April 21, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants