Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Restructure how the planner and optimizer are called #537

Closed
joocer opened this issue Sep 19, 2022 · 2 comments
Closed

🧹 Restructure how the planner and optimizer are called #537

joocer opened this issue Sep 19, 2022 · 2 comments
Labels
Debt 💰 Things that were done, but should be fixed High Priority 1️⃣

Comments

@joocer
Copy link
Contributor

joocer commented Sep 19, 2022

Planner mostly rewritten and working for basic queries. Some functions currently don't work; such as subqueries and explain

joocer added a commit that referenced this issue Sep 19, 2022
joocer added a commit that referenced this issue Sep 19, 2022
joocer added a commit that referenced this issue Sep 20, 2022
@joocer joocer added Debt 💰 Things that were done, but should be fixed High Priority 1️⃣ labels Sep 20, 2022
joocer added a commit that referenced this issue Sep 20, 2022
joocer added a commit that referenced this issue Sep 21, 2022
joocer added a commit that referenced this issue Sep 21, 2022
@joocer joocer pinned this issue Sep 21, 2022
joocer added a commit that referenced this issue Sep 21, 2022
joocer added a commit that referenced this issue Sep 22, 2022
joocer added a commit that referenced this issue Sep 23, 2022
joocer added a commit that referenced this issue Sep 24, 2022
joocer added a commit that referenced this issue Sep 24, 2022
joocer added a commit that referenced this issue Sep 24, 2022
joocer added a commit that referenced this issue Sep 24, 2022
joocer added a commit that referenced this issue Sep 24, 2022
joocer added a commit that referenced this issue Sep 24, 2022
joocer added a commit that referenced this issue Sep 24, 2022
joocer added a commit that referenced this issue Sep 24, 2022
joocer added a commit that referenced this issue Sep 24, 2022
joocer added a commit that referenced this issue Sep 24, 2022
joocer added a commit that referenced this issue Sep 24, 2022
joocer added a commit that referenced this issue Sep 25, 2022
joocer added a commit that referenced this issue Sep 25, 2022
joocer added a commit that referenced this issue Sep 25, 2022
joocer added a commit that referenced this issue Sep 25, 2022
joocer added a commit that referenced this issue Sep 25, 2022
joocer added a commit that referenced this issue Sep 25, 2022
joocer added a commit that referenced this issue Sep 25, 2022
@joocer
Copy link
Contributor Author

joocer commented Sep 25, 2022

Problem with passing context (dates, params) should be resolved by the binder and not require the context to be handled by the subqueries.

The binder should add additional properties to the AST. This will likely need a AST visitor pattern.

joocer added a commit that referenced this issue Sep 25, 2022
joocer added a commit that referenced this issue Sep 25, 2022
joocer added a commit that referenced this issue Sep 25, 2022
joocer added a commit that referenced this issue Sep 25, 2022
joocer added a commit that referenced this issue Sep 25, 2022
joocer added a commit that referenced this issue Sep 25, 2022
@joocer
Copy link
Contributor Author

joocer commented Sep 26, 2022

This needs a minor refactor.

The Parser and Lexer should be called once and return an iterable of ASTs (which is kind of what it does at the moment).

These ASTs should then be executed to the end in turn:

  • bind (because the execution of a query may change how the next query is bound)
  • planned (because we can't plan until we're bound)
  • optimize (because we can't plan until we're bound)
  • execute (because the execution of query may change the outcome)

This isn't how this works at the moment.

joocer added a commit that referenced this issue Sep 26, 2022
joocer added a commit that referenced this issue Sep 27, 2022
joocer added a commit that referenced this issue Sep 27, 2022
joocer added a commit that referenced this issue Sep 27, 2022
joocer added a commit that referenced this issue Sep 27, 2022
joocer added a commit that referenced this issue Sep 27, 2022
joocer added a commit that referenced this issue Sep 27, 2022
joocer added a commit that referenced this issue Sep 27, 2022
joocer added a commit that referenced this issue Sep 27, 2022
joocer added a commit that referenced this issue Sep 27, 2022
@joocer joocer closed this as completed Sep 28, 2022
@joocer joocer unpinned this issue Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Debt 💰 Things that were done, but should be fixed High Priority 1️⃣
Projects
None yet
Development

No branches or pull requests

1 participant