Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ma_device_notification_type_invalidated. currently implemente… #962

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Aleksoid1978
Copy link

Currently implemented only for WASAPI MA_AUDCLNT_E_DEVICE_INVALIDATED (https://learn.microsoft.com/en-us/windows/win32/coreaudio/recovering-from-an-invalid-device-error).

@mackron mackron changed the base branch from master to dev March 13, 2025 22:33
@mackron
Copy link
Owner

mackron commented Mar 13, 2025

Thanks. I'm going to sit on this. Handling of INVALIDATED makes sense, but I'm not sure I want to just post a notification. I'm wondering if instead miniaudio should just try recovering, and then if recovery fails just stop the device. I'll consider this and report back.

@Aleksoid1978
Copy link
Author

Well, in theory, you can try calling ma_device_reroute__wasapi - and in case of an error return, notify and exit with an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants