Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

优化 README 样式 #12

Merged
merged 1 commit into from
Nov 27, 2024
Merged

优化 README 样式 #12

merged 1 commit into from
Nov 27, 2024

Conversation

vivodi
Copy link
Contributor

@vivodi vivodi commented Oct 28, 2024

No description provided.

@vivodi vivodi closed this Oct 28, 2024
@vivodi vivodi reopened this Oct 28, 2024
@vivodi vivodi marked this pull request as draft October 28, 2024 05:58
@vivodi vivodi marked this pull request as ready for review November 1, 2024 13:47
@vivodi
Copy link
Contributor Author

vivodi commented Nov 4, 2024

已经可以合并了 @madwind

  1. 之前写的 workflow 对 pr 的检查在某些情况下有问题,所以显示失败,其实是没有问题的。
  2. 本 pr 主要是对我之前代码的整理,Dockerfile 完全没改,运行方式也没改。
  3. 新增了自动合并依赖更新的 pr,但触发条件已经被我注释掉了。
  4. 本 pr 不会引入新的 bug,可以放心合并

@madwind
Copy link
Owner

madwind commented Nov 22, 2024

dockerfile 已经修改, 频繁更新镜像不是很好 matplotlib依赖复杂 经常更新了就不能用

@vivodi
Copy link
Contributor Author

vivodi commented Nov 26, 2024

此 PR 和 @madwind Dockerfile 的修改没有冲突。因为 requirements.txt 已锁定依赖版本,而本 PR 没有修改 Dockerfilerequirements.txt,故本 PR 生成的 Docker image 与之前不会有任何区别,没有修改依赖,不会导致不能用,请放心合并。

本 PR 仅对 workflow 和 README 进行了修改,而不会改变最终生成的 image。故本 PR 不会导致任何错误。

@vivodi
Copy link
Contributor Author

vivodi commented Nov 26, 2024

matplotlib 已锁定依赖,而本 PR 并未对其进行任何修改。

matplotlib==3.9.2

即使 matplotlib 依赖再复杂,本 PR 也可以放心合并。

@madwind madwind merged commit c1410dd into madwind:main Nov 27, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants