Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable bar-style fake cursors #367

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

smithzvk
Copy link
Contributor

I use bar style cursors and have had issues with the fake cursor rendered in a "bar style". I have been disabling this feature for years, but figured it might be nice to have an official customization to do so.

@smithzvk
Copy link
Contributor Author

This failure seems unrelated to this change. A Emacs-24 builds broken for some other reason right now?

@smithzvk
Copy link
Contributor Author

smithzvk commented Dec 10, 2020

I see that there is discussion about this issue on the original PR #253 introducing this behavior and there is a live PR which is attempting to fix a related issue in a different way, #366. The suggested solution from the original PR author, @jtamagnan, is to clobber the mc/cursor-is-bar function with something like:

(defun mc/cursor-is-bar () nil)

...after load. I'm switching to that for know as I'm tired of remembering to patch this library every time there is an update.

I think this whole "render fake cursors as bars" functionality is causing more trouble than it is worth, but the clobber method is a viable solution for me if we're all too busy to consider this PR or don't want this change for whatever reason.

I'll leave it open, feel free to close as you see fit.

@jtamagnan jtamagnan merged commit a9d7764 into magnars:master Dec 15, 2020
@jtamagnan
Copy link
Collaborator

Sorry this took so long to look at! Looks good to me! Thank you for your patience and the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants