Bug with pad options in timeComponents()/timeComponentsSinceNow() in Date/DateInRegion and .string() of TimeInterval. New formatter options struct.

[digidhamu]

I am not sure how SwiftDate API works to replace Swift 3 function given below. Basically, this function converts seconds to format hh:mm:ss.

In this case, below Swift 3 code is working fine. But in SwiftDate, not padding Zero e.g. 40:01 rather returns 40:1.

Some more sample
1:01 - 1:1 (no zero)
12:01 -> 12:1 (no zero)
12:20 -> 12:20 (only this works)

Could you please advise anything wrong in using API and even I had tried DateZeroBehaviour as arguments.

Swift 3 Style

open class func secondsToTimeString(_ seconds: TimeInterval) -> String {
  let formatter = DateComponentsFormatter()
  formatter.zeroFormattingBehavior = .pad

  if seconds >= 3600 {
    formatter.allowedUnits = [.hour, .minute, .second]
  } else {
    formatter.allowedUnits = [.minute, .second]
  }  
    return formatter.string(from: seconds) ?? ""
}

SwiftDate Style

open class func secondsToTimeString(_ seconds: TimeInterval) -> String {
  let refDate = Date()
  let toDate = refDate + Int(seconds).seconds

  do {
    return try (refDate - toDate).string(unitStyle: .positional, max: 4, zero: nil, separator: ":", locale: nil)!
  } catch {
    return ""
  }
}

[malcommac]

You are right.
I've fixed it in 6d811aa.
It will be ready in upcoming 4.0.3 release (I'll release it later tomorrow).

Your function will become:

open class func secondsToTimeString(_ seconds: TimeInterval) -> String {
  let refDate = Date()
  let toDate = refDate + Int(seconds).seconds
  do {
    return try (refDate - toDate).string(options: ComponentsFormatterOptions(zero: .pad))
  } catch {
    return ""
  }
}

These function are now deprecated:

in Date:

func timeComponentsSinceNow(unitStyle:,max:,zero:,separator:) throws -> String
func timeComponents(to:,in:,unitStyle:,max:,zero:,separator:) throws -> String

replaced by:

func timeComponentsSinceNow(options:,shared:) throws -> String
func timeComponents(to:options:shared:) throws -> String

in DateInRegion:

func timeComponentsSinceNow(unitStyle:,max:,zero:,separator:) throws -> String
func timeComponents(toDate,unitStyle:,max:,zero:,separator:) throws -> String

replaced by:

func timeComponentsSinceNow(options:) throws -> String
func timeComponents(toDate:,options:) throws -> String

in TimeInterval:

func string(unitStyle:,max:,zero:,separator:,locale:) throws -> String?

replaced by:

func string(options:,shared:) throws -> String

[digidhamu]

Great @malcommac. Thanks