Skip to content

Commit

Permalink
#835: fixed bug with dtale.show(open_browser=True)
Browse files Browse the repository at this point in the history
  • Loading branch information
aschonfeld committed Jan 5, 2024
1 parent 954f6be commit 70c651b
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion dtale/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,8 @@ def __init__(self, data_id, url, is_proxy=False, app_root=None):
self.app_root = app_root

def build_main_url(self, name=None):
if name or self._data_id:
data_keys = global_state.keys()
if (name or self._data_id) and len(data_keys):
quoted_data_id = get_url_quote()(
get_url_quote()(name or self._data_id, safe="")
)
Expand All @@ -261,6 +262,9 @@ def build_main_url(self, name=None):

@property
def _main_url(self):
data_keys = global_state.keys()
if not len(data_keys):
return self.build_main_url()
suffix = self._data_id
name = global_state.get_name(suffix)
if name:
Expand Down

0 comments on commit 70c651b

Please sign in to comment.