Turn global_state into interfaces #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschonfeld
requested changes
Feb 16, 2021
dtale/views.py
Outdated
Comment on lines
175
to
176
| if data_id != None: | ||
| data_id = int(data_id) |
There was a problem hiding this comment.
data_id = data_id if data_id is None else int(data_id)
Suggested change
| if data_id != None: | |
| data_id = int(data_id) | |
| data_id = data_id if data_id is None else int(data_id) |
Co-authored-by: Andrew Schonfeld <[email protected]>
aschonfeld
requested changes
Feb 17, 2021
aschonfeld
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this humongous PR is to consolidate properties of data instance distributed in global variables into properties of newly created DtaleInstance and DefaultStore class. This allows easy expansion of data instance properties and easy implementation of custom store classes. It would also allow multiple store instances to be created without too much modification. I managed to fix as many tests as possible but there are still a few keep getting error.