Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor run to use isolated scripts #37

Merged
merged 10 commits into from
Nov 1, 2024
Merged

Refactor run to use isolated scripts #37

merged 10 commits into from
Nov 1, 2024

Conversation

manzt
Copy link
Owner

@manzt manzt commented Oct 31, 2024

This PR aligns juv's script support closer to what uv has built-in. Previously we were handling the PEP 723 metadata ourselves, but now we just forward it down to uv.

This has several benefits:

  • 1.) speed (the isolated enviroments are more cachable)
  • 2.) linking of local packages into the notebook
  • 3.) alignment with uv run <script> also means that we will benefit from whatever features are added to scripts going forward.

The trickiest bit in this was getting the jupyter data dirs set up ephemerally using the uv cached environments.

@manzt manzt changed the title Refactor run to use isolated templates Refactor run to use isolated scripts Nov 1, 2024
@manzt manzt merged commit c641f60 into main Nov 1, 2024
13 checks passed
@manzt manzt added the enhancement New feature or request label Nov 1, 2024
@manzt manzt deleted the manzt/dynamic-script branch November 8, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant