Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to local glyph rendering if glyph PBF is unavailable #4564

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Fall back to local glyph rendering if glyph PBF is unavailable

a56d0f8
Select commit
Loading
Failed to load commit list.
Open

Fall back to local glyph rendering if glyph PBF is unavailable #4564

Fall back to local glyph rendering if glyph PBF is unavailable
a56d0f8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 12, 2024 in 0s

87.97% (+0.22%) compared to 42d6847

View this Pull Request on Codecov

87.97% (+0.22%) compared to 42d6847

Details

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.97%. Comparing base (42d6847) to head (a56d0f8).
Report is 369 commits behind head on main.

Files with missing lines Patch % Lines
src/render/glyph_manager.ts 85.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4564      +/-   ##
==========================================
+ Coverage   87.74%   87.97%   +0.22%     
==========================================
  Files         247      247              
  Lines       33494    33510      +16     
  Branches     2414     2375      -39     
==========================================
+ Hits        29390    29481      +91     
+ Misses       3118     3058      -60     
+ Partials      986      971      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.