Martin-ui packaging issue

[nyurik]

Seems we still have a packaging issue - npm saves files outside the build dir.

error: failed to verify package tarball

Caused by:
  Source directory was modified by build.rs during cargo publish. Build scripts should not modify anything outside of OUT_DIR.
  Added: .../martin/target/package/martin-0.15.0/martin-ui/dist
  	.../martin/target/package/martin-0.15.0/martin-ui/dist/_
  	.../martin/target/package/martin-0.15.0/martin-ui/dist/_/assets
        ...

Fixes #1667
See prior partial fix in #1668

[CommanderStorm]

Let me prephase this: What I have just pushed is a hooorible hack.

What I just pushed works locally (both publish and running).. wish me luck

[CommanderStorm]

I will not continue working on this today, seems like CI is really against this change..
I need fresh eyes for this => will continue sometime in the week/on the weekend.

If someone wants to look into this or has better oppinions, I would love feedback.

Somewhere I apparently made a change in the code I pushed during final cleanup (=before my first commit here) 😞

[CommanderStorm]

Okay.. this works now.
It is still a hoooorible hack, but at least it woks

[nyurik]

thx, i refactored the build script a bit further, trying to simplify it (not much luck), plus made sure not to use results - with build, its ok to crash asap as it gives us good debugging context. When we build with the npm packaging command, where does the generated file end up in? I only see dist/index.html.

If everything is ok, lets merge

[CommanderStorm]

When we build with the npm packaging command, where does the generated file end up in? I only see dist/index.html.

what do you mean? Not quite sure what you are asking
It is in the OUT_DIR, more precicely most of from the node build generated files will end up in the _ folder.

[CommanderStorm]

Looks good to me
Could be merged as is, asssuming rerun-if-changed is correct ^^

[nyurik]

thanks! Turns out I shouldn't code at night - didn't notice the _ dir. Thank you for good suggestions, will merge shortly.

[CommanderStorm]

LGTM
I think we can remove the TODO though

[CommanderStorm]

Could you clairify what you mean here?
When I rebuild, this should be reproducible enough to depend on the input files and not on the output file..

As far as I see it, this is a non-issue..

Suggested change

// TODO: we may need to move index.html one level down per change_detection() docs

[nyurik]

Thanks @CommanderStorm for tackling this one! Messy, but it seems like it works now :)

This is why i put that todo (which we might want to remove later):

https://github.com/static-files-rs/static-files/blob/bac6352faddffdc36d96cac04b4115dfd6f2f35e/src/mods/npm_build.rs#L81-L93