Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tags API] fix: avoid long assignment chains in serializer #2545

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Conversation

DylanPiercey
Copy link
Contributor

@DylanPiercey DylanPiercey commented Mar 4, 2025

Apparently this breaks in v8...

var x = {};

x.a=x.b=x.c=x.d=x.e=x.f=x.g=x.h=x.i=x.j=x.k=x.l=x.m=x.n=x.o=x.p=x.q=x.r=x.s=x.t=x.u=x.v=x.w=x.x=x.y=x.z=x.A=x.B=x.C=x.D=x.E=x.F=x.G=x.H=x.I=x.J=x.K=x.L=x.M=x.N=x.O=x.P=x.Q=x.R=x.S=x.T=x.U=x.V=x.W=x.X=x.Y=x.Z=x.$=x.ab=x.bb=x.cb=x.db=x.eb=x.fb=x.gb=x.hb=x.ib=x.jb=x.kb=x.lb=x.mb=x.nb=x.ob=x.pb=x.qb=x.rb=x.sb=x.tb=x.ub=x.vb=x.wb=x.xb=x.yb=x.zb=x.Ab=x.Bb=x.Cb=x.Db=x.Eb=x.Fb=x.Gb=x.Hb=x.Ib=x.Jb=x.Kb=x.Lb=x.Mb=x.Nb=x.Ob=x.Pb=x.Qb=x.Rb=x.Sb=x.Tb=x.Ub=x.Vb=x.Wb=x.Xb=x.Yb=x.Zb=x.$b=x.ac=x.bc=x.cc=x.dc=x.ec=x.fc=x.gc=x.hc=x.ic=x.jc=x.kc=x.lc=x.mc=x.nc=x.oc=x.pc=x.qc=x.rc=x.sc=x.tc=x.uc=x.vc=x.wc=x.xc=x.yc=x.zc=x.Ac=x.Bc=x.Cc=x.Dc=x.Ec=x.Fc=x.Gc=x.Hc=x.Ic=x.Jc=x.Kc=x.Lc=x.Mc=x.Nc=x.Oc=x.Pc=x.Qc=x.Rc=x.Sc=x.Tc=x.Uc=x.Vc=x.Wc=x.Xc=x.Yc=x.Zc=x.$c=x.ad=x.bd=x.cd=x.dd=x.ed=x.fd=x.gd=x.hd=x.id=x.jd=x.kd=x.ld=x.md=x.nd=x.od=x.pd=x.qd=x.rd=x.sd=x.td=x.ud=x.vd=x.wd=x.xd=x.yd=x.zd=x.Ad=x.Bd=x.Cd=x.Dd=x.Ed=x.Fd=x.Gd=x.Hd=x.Id=x.Jd=x.Kd=x.Ld=x.Md=x.Nd=x.Od=x.Pd=x.Qd=x.Rd=x.Sd=x.Td=x.Ud=x.Vd=x.Wd=x.Xd=x.Yd=x.Zd=x.$d=x.ae=x.be=x.ce=x.de=x.ee=x.fe=x.ge=x.he=x.ie=x.je=x.ke=x.le=x.me=x.ne=x.oe=x.pe=x.qe=x.re=x.se=x.te=x.ue=x.ve=x.we=x.xe=x.ye=x.ze=x.Ae=x.Be=x.Ce=x.De=x.Ee=x.Fe=x.Ge=x.He=x.Ie=x.Je=x.Ke=x.Le=x.Me=x.Ne=x.Oe=x.Pe=x.Qe=x.Re=x.Se=x.Te=x.Ue=x.Ve=x.We=x.Xe=x.Ye=x.Ze=x.$e=x.af=x.bf=x.cf=x.df=x.ef=x.ff=x.gf=x.hf=x.if=x.jf=x.kf=x.lf=x.mf=x.nf=x.of=x.pf=x.qf=x.rf=x.sf=x.tf=x.uf=x.vf=x.wf=x.xf=x.yf=x.zf=x.Af=x.Bf=x.Cf=x.Df=x.Ef=x.Ff=x.Gf=x.Hf=x.If=x.Jf=x.Kf=x.Lf=x.Mf=x.Nf=x.Of=x.Pf=x.Qf=x.Rf=x.Sf=x.Tf=x.Uf=x.Vf=x.Wf=x.Xf=x.Yf=x.Zf=x.$f=x.ag=x.bg=x.cg=x.dg=x.eg=x.fg=x.gg=x.hg=x.ig=x.jg=x.kg=x.lg=x.mg=x.ng=x.og=x.pg=x.qg=x.rg=x.sg=x.tg=x.ug=x.vg=x.wg=x.xg=x.yg=x.zg=x.Ag=x.Bg=x.Cg=x.Dg=x.Eg=x.Fg=x.Gg=x.Hg=x.Ig=x.Jg=x.Kg=x.Lg=x.Mg=x.Ng=x.Og=x.Pg=x.Qg=x.Rg=x.Sg=x.Tg=x.Ug=x.Vg=x.Wg=x.Xg=x.Yg=x.Zg=x.$g=x.ah=x.bh=x.ch=x.dh=x.eh=x.fh=x.gh=x.hh=x.ih=x.jh=x.kh=x.lh=x.mh=x.nh=x.oh=x.ph=x.qh=x.rh=x.sh=x.th=x.uh=x.vh=x.wh=x.xh=x.yh=x.zh=x.Ah=x.Bh=x.Ch=x.Dh=x.Eh=x.Fh=x.Gh=x.Hh=x.Ih=x.Jh=x.Kh=x.Lh=x.Mh=x.Nh=x.Oh=x.Ph=x.Qh=x.Rh=x.Sh=x.Th=x.Uh=x.Vh=x.Wh=x.Xh=x.Yh=x.Zh=x.$h=x.ai=x.bi=x.ci=x.di=x.ei=x.fi=x.gi=x.hi=x.ii=x.ji=x.ki=x.li=x.mi=x.ni=x.oi=x.pi=x.qi=x.ri=x.si=x.ti=x.ui=x.vi=x.wi=x.xi=x.yi=x.zi=x.Ai=x.Bi=x.Ci=x.Di=x.Ei=x.Fi=x.Gi=x.Hi=x.Ii=x.Ji=x.Ki=x.Li=x.Mi=x.Ni=x.Oi=x.Pi=x.Qi=x.Ri=x.Si=x.Ti=x.Ui=x.Vi=x.Wi=x.Xi=x.Yi=x.Zi=x.$i=x.aj=x.bj=x.cj=x.dj=x.ej=x.fj=x.gj=x.hj=x.ij=x.jj=x.kj=x.lj=x.mj=x.nj=x.oj=x.pj=x.qj=x.rj=x.sj=x.tj=x.uj=x.vj=x.wj=x.xj=x.yj=x.zj=x.Aj=x.Bj=x.Cj=x.Dj=x.Ej=x.Fj=x.Gj=x.Hj=x.Ij=x.Jj=x.Kj=x.Lj=x.Mj=x.Nj=x.Oj=x.Pj=x.Qj=x.Rj=x.Sj=x.Tj=x.Uj=x.Vj=x.Wj=x.Xj=x.Yj=x.Zj=x.$j=x.ak=x.bk=x.ck=x.dk=x.ek=x.fk=x.gk=x.hk=x.ik=x.jk=x.kk=x.lk=x.mk=x.nk=x.ok=x.pk=x.qk=x.rk=x.sk=x.tk=x.uk=x.vk=x.wk=x.xk=x.yk=x.zk=x.Ak=x.Bk=x.Ck=x.Dk=x.Ek=x.Fk=x.Gk=x.Hk=x.Ik=x.Jk=x.Kk=x.Lk=x.Mk=x.Nk=x.Ok=x.Pk=x.Qk=x.Rk=x.Sk=x.Tk=x.Uk=x.Vk=x.Wk=x.Xk=x.Yk=x.Zk=x.$k=x.al=x.bl=x.cl=x.dl=x.el=x.fl=x.gl=x.hl=x.il=x.jl=x.kl=x.ll=x.ml=x.nl=x.ol=x.pl=x.ql=x.rl=x.sl=x.tl=x.ul=x.vl=x.wl=x.xl=x.yl=x.zl=x.Al=x.Bl=x.Cl=x.Dl=x.El=x.Fl=x.Gl=x.Hl=x.Il=x.Jl=x.Kl=x.Ll=x.Ml=x.Nl=x.Ol=x.Pl=x.Ql=x.Rl=x.Sl=x.Tl=x.Ul=x.Vl=x.Wl=x.Xl=x.Yl=x.Zl=x.$l=x.am=x.bm=x.cm=x.dm=x.em=x.fm=x.gm=x.hm=x.im=x.jm=x.km=x.lm=x.mm=x.nm=x.om=x.pm=x.qm=x.rm=x.sm=x.tm=x.um=x.vm=x.wm=x.xm=x.ym=x.zm=x.Am=x.Bm=x.Cm=x.Dm=x.Em=x.Fm=x.Gm=x.Hm=x.Im=x.Jm=x.Km=x.Lm=x.Mm=x.Nm=x.Om=x.Pm=x.Qm=x.Rm=x.Sm=x.Tm=x.Um=x.Vm=x.Wm=x.Xm=x.Ym=x.Zm=x.$m=x.an=x.bn=x.cn=x.dn=x.en=x.fn=x.gn=x.hn=x.in=x.jn=x.kn=x.ln=x.mn=x.nn=x.on=x.pn=x.qn=x.rn=x.sn=x.tn=x.un=x.vn=x.wn=x.xn=x.yn=x.zn=x.An=x.Bn=x.Cn=x.Dn=x.En=x.Fn=x.Gn=x.Hn=x.In=x.Jn=x.Kn=x.Ln=x.Mn=x.Nn=x.On=x.Pn=x.Qn=x.Rn=x.Sn=x.Tn=x.Un=x.Vn=x.Wn=x.Xn=x.Yn=x.Zn=x.$n=x.ao=x.bo=x.co=x.do=x.eo=x.fo=x.go=x.ho=x.io=x.jo=x.ko=x.lo=x.mo=x.no=x.oo=x.po=x.qo=x.ro=x.so=x.to=x.uo=x.vo=x.wo=x.xo=x.yo=x.zo=x.Ao=x.Bo=x.Co=x.Do=x.Eo=x.Fo=x.Go=x.Ho=x.Io=x.Jo=x.Ko=x.Lo=x.Mo=x.No=x.Oo=x.Po=x.Qo=x.Ro=x.So=x.To=x.Uo=x.Vo=x.Wo=x.Xo=x.Yo=x.Zo=x.$o=x.ap=x.bp=x.cp=x.dp=x.ep=x.fp=x.gp=x.hp=x.ip=x.jp=x.kp=x.lp=x.mp=x.np=x.op=x.pp=x.qp=x.rp=x.sp=x.tp=x.up=x.vp=x.wp=x.xp=x.yp=x.zp=x.Ap=x.Bp=x.Cp=x.Dp=x.Ep=x.Fp=x.Gp=x.Hp=x.Ip=x.Jp=x.Kp=x.Lp=x.Mp=x.Np=x.Op=x.Pp=x.Qp=x.Rp=x.Sp=x.Tp=x.Up=x.Vp=x.Wp=x.Xp=x.Yp=x.Zp=x.$p=x.aq=x.bq=x.cq=x.dq=x.eq=x.fq=x.gq=x.hq=x.iq=x.jq=x.kq=x.lq=x.mq=x.nq=x.oq=x.pq=x.qq=x.rq=x.sq=x.tq=x.uq=x.vq=x.wq=x.xq=x.yq=x.zq=x.Aq=x.Bq=x.Cq=x.Dq=x.Eq=x.Fq=x.Gq=x.Hq=x.Iq=x.Jq=x.Kq=x.Lq=x.Mq=x.Nq=x.Oq=x.Pq=x.Qq=x.Rq=x.Sq=x.Tq=x.Uq=x.Vq=x.Wq=x.Xq=x.Yq=x.Zq=x.$q=x.ar=x.br=x.cr=x.dr=x.er=x.fr=x.gr=x.hr=x.ir=x.jr=x.kr=x.lr=x.mr=x.nr=x.or=x.pr=x.qr=x.rr=x.sr=x.tr=x.ur=x.vr=x.wr=x.xr=x.yr=x.zr=x.Ar=x.Br=x.Cr=x.Dr=x.Er=x.Fr=x.Gr=x.Hr=x.Ir=x.Jr=x.Kr=x.Lr=x.Mr=x.Nr=x.Or=x.Pr=x.Qr=x.Rr=x.Sr=x.Tr=x.Ur=x.Vr=x.Wr=x.Xr=x.Yr=x.Zr=x.$r=x.as=x.bs=x.cs=x.ds=x.es=x.fs=x.gs=x.hs=x.is=x.js=x.ks=x.ls=x.ms=x.ns=x.os=x.ps=x.qs=x.rs=x.ss=x.ts=x.us=x.vs=x.ws=x.xs=x.ys=x.zs=x.As=x.Bs=x.Cs=x.Ds=x.Es=x.Fs=x.Gs=x.Hs=x.Is=x.Js=x.Ks=x.Ls=x.Ms=x.Ns=x.Os=x.Ps=x.Qs=x.Rs=x.Ss=x.Ts=x.Us=x.Vs=x.Ws=x.Xs=x.Ys=x.Zs=x.$s=x.at=x.bt=x.ct=x.dt=x.et=x.ft=x.gt=x.ht=x.it=x.jt=x.kt=x.lt=x.mt=x.nt=x.ot=x.pt=x.qt=x.rt=x.st=x.tt=x.ut=x.vt=x.wt=x.xt=x.yt=x.zt=x.At=x.Bt=x.Ct=x.Dt=x.Et=x.Ft=x.Gt=x.Ht=x.It=x.Jt=x.Kt=x.Lt=x.Mt=x.Nt=x.Ot=x.Pt=x.Qt=x.Rt=x.St=x.Tt=x.Ut=x.Vt=x.Wt=x.Xt=x.Yt=x.Zt=x.$t=x.au=x.bu=x.cu=x.du=x.eu=x.fu=x.gu=x.hu=x.iu=x.ju=x.ku=x.lu=x.mu=x.nu=x.ou=x.pu=x.qu=x.ru=x.su=x.tu=x.uu=x.vu=x.wu=x.xu=x.yu=x.zu=x.Au=x.Bu=x.Cu=x.Du=x.Eu=x.Fu=x.Gu=x.Hu=x.Iu=x.Ju=x.Ku=x.Lu=x.Mu=x.Nu=x.Ou=x.Pu=x.Qu=x.Ru=x.Su=x.Tu=x.Uu=x.Vu=x.Wu=x.Xu=x.Yu=x.Zu=x.$u=x.av=x.bv=x.cv=x.dv=x.ev=x.fv=x.gv=x.hv=x.iv=x.jv=x.kv=x.lv=x.mv=x.nv=x.ov=x.pv=x.qv=x.rv=x.sv=x.tv=x.uv=x.vv=x.wv=x.xv=x.yv=x.zv=x.Av=x.Bv=x.Cv=x.Dv=x.Ev=x.Fv=x.Gv=x.Hv=x.Iv=x.Jv=x.Kv=x.Lv=x.Mv=x.Nv=x.Ov=x.Pv=x.Qv=x.Rv=x.Sv=x.Tv=x.Uv=x.Vv=x.Wv=x.Xv=x.Yv=x.Zv=x.$v=x.aw=x.bw=x.cw=x.dw=x.ew=x.fw=x.gw=x.hw=x.iw=x.jw=x.kw=x.lw=x.mw=x.nw=x.ow=x.pw=x.qw=x.rw=x.sw=x.tw=x.uw=x.vw=x.ww=x.xw=x.yw=x.zw=1;

Note:
An assignment chain with 1192 members breaks. 1191 is fine 😓
The serializer has been updated to bail the assignment chain if it's larger than 100 assignments.

Copy link

changeset-bot bot commented Mar 4, 2025

🦋 Changeset detected

Latest commit: 8415cf9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/runtime-tags Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 95.83333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.06%. Comparing base (85211c1) to head (8415cf9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/runtime-tags/src/html/serializer.ts 95.83% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2545   +/-   ##
=======================================
  Coverage   87.05%   87.06%           
=======================================
  Files         352      352           
  Lines       40951    40984   +33     
  Branches     2770     2777    +7     
=======================================
+ Hits        35651    35682   +31     
- Misses       5276     5278    +2     
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit be54ab2 into main Mar 4, 2025
10 checks passed
@DylanPiercey DylanPiercey deleted the wip branch March 4, 2025 18:07
@github-actions github-actions bot mentioned this pull request Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant