Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20.6-DEV Merge #153

Conversation

sakura-ryoko
Copy link

@sakura-ryoko sakura-ryoko commented Apr 21, 2024

I accidentally merged my DEV branch making the original one too ugly...
Draft RC.2 Clean Merge from DEV branch.

  • Includes a direct clone of SRC folder.
  • Gradle 8.7 files.
  • Lacks: build.gradle / gradle.properties
  • Requires: Java 21 / Fabric-Loom 1.6 / fabric-network-api
  • Modmenu (A newer build after alpha.3 that doesn't break malilib at launch)

Fixes / Changes:

  • Fixes MOD_VERSION to be displayed in the config menu.
  • Allows the mod to actually save the "Debug" section of the settings to the config file.\
  • Introduces the ServerHandler interfaces, for Server-related events (More on this later)
  • Converts the majority of the Rendering code to be Matrix4f / Matrix4fStack compliant, with a few exceptions, such as DrawContext.
  • Fixes WorldLoadHandler's "joinWorld / disconnect" code to work with the new version.
  • Removes legacy PluginChannelHandler and PacketSplitter code in favor of a totally new Network API that supports the new CustomPayload format, and Fabric Networking API 4.0.0+. There is a lot to explain on this subject in addition to the new Client and Server side Packet / Channel Handler interfaces.
  • Fixed several functions under InventoryUtils to work with the new Data Components interface under Minecraft, such as replacing the getStoredItems() for shulker boxes.
  • Added functions for getBundleItems() to match it's Shulker box counterpart.
  • Moved the "getItemStackFromString()" function to MaLiLib from Litematica, and expanded it to allow both Item counts, and Data Components as parameters. This function is used across various mods.
  • Added "getHighestSectionYOffset()" function to WorldUtils to replace the Vanilla "getHighestNonEmptySectionYOffset()" which is marked for removal.

@sakura-ryoko sakura-ryoko marked this pull request as ready for review April 21, 2024 17:59
@sakura-ryoko sakura-ryoko marked this pull request as draft April 21, 2024 19:00
@sakura-ryoko sakura-ryoko changed the title 1.20.5-RC2 DEV Merge (Oops) 1.20.5-RC2 DEV Merge Apr 21, 2024
@sakura-ryoko sakura-ryoko marked this pull request as ready for review April 21, 2024 23:16
@sakura-ryoko sakura-ryoko changed the title 1.20.5-RC2 DEV Merge 1.20.5-RC3 DEV Merge Apr 23, 2024
@sakura-ryoko sakura-ryoko changed the title 1.20.5-RC3 DEV Merge 1.20.5-DEV Merge Apr 23, 2024
@watertrainer
Copy link

I was able to compile everything with the provided build.gradle, minihud, litematica and tweakeroo worked like a charm ingame as well

@sakura-ryoko
Copy link
Author

I was able to compile everything with the provided build.gradle, minihud, litematica and tweakeroo worked like a charm ingame as well

Did you change them to 1.20.5, though ? Also there are .JAR files in the repos.

@watertrainer
Copy link

watertrainer commented Apr 27, 2024

I was able to compile everything with the provided build.gradle, minihud, litematica and tweakeroo worked like a charm ingame as well

Did you change them to 1.20.5, though ? Also there are .JAR files in the repos.

I didn't have to change anything in the gradle files, they were set to 1.20.5 already and the compiled files worked for me (with your branches of those mods as well). I had to add a new libs folder in tweakeroo, minihud and litematica and add the custom malilib, but apart from that all the preset settings etc. worked for me

@sakura-ryoko
Copy link
Author

sakura-ryoko commented Apr 27, 2024

I didn't have to change anything in the gradle files, they were set to 1.20.5 already and the compiled files worked for me (with your branches of those mods as well). I had to add a new libs folder in tweakeroo, minihud and litematica and add the custom malilib, but apart from that all the preset settings etc. worked for me

You must have used the -DEV branch then. This PR is a src file clone of the DEV branch, minus the build scripts.
And correct, you just need to copy the malilib to the libs folder --> or just download the existing JAR files.

@sakura-ryoko sakura-ryoko changed the title 1.20.5-DEV Merge 1.20.6-DEV Merge Apr 30, 2024
@sakura-ryoko sakura-ryoko mentioned this pull request May 3, 2024
@sakura-ryoko sakura-ryoko deleted the pre-rewrite/fabric/1.20.5-PR branch June 20, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants