Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

서버쪽과 TeamId 상수값이 일치하도록 수정 #226

Merged
merged 1 commit into from
Jan 10, 2023
Merged

서버쪽과 TeamId 상수값이 일치하도록 수정 #226

merged 1 commit into from
Jan 10, 2023

Conversation

HaJunRyu
Copy link
Member

@HaJunRyu HaJunRyu commented Jan 10, 2023 •
edited
Loading

변경사항

  • 서버에서 dev환경에서의 TeamId와 production환경에서의 TeamId가 다르게 설정되어있어 지원서 생성시 선택한 플랫폼이 아닌 다른 플랫폼의 설문지를 응답받게 되는 이슈가 있어 이를 해결해주었습니다.

작업 유형

  • 버그 수정

체크리스트

  • Merge 할 브랜치가 올바른가?
  • 코딩컨벤션을 준수하였는가?
  • 해당 PR과 관련없는 변경사항이 없는가? (만약 있다면 제목이나 변경사항에 기술하여 주세요.)
  • 실행시 console 창에 에러나 경고가 없는것을 확인하였는가? (개발에 필요하여 고의적으로 남겨둔것 제외)

@HaJunRyu HaJunRyu self-assigned this Jan 10, 2023
@HaJunRyu HaJunRyu requested a review from sanoopark as a code owner January 10, 2023 15:44
Baek2back
Baek2back approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@Baek2back Baek2back left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@HaJunRyu HaJunRyu merged commit 67b1dc1 into release/v1.0.1 Jan 10, 2023
@HaJunRyu HaJunRyu deleted the fix/platform-team-id branch January 10, 2023 15:45
@HaJunRyu HaJunRyu mentioned this pull request Jan 10, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baek2back Baek2back Baek2back approved these changes

@mango906 mango906 Awaiting requested review from mango906

@sanoopark sanoopark Awaiting requested review from sanoopark

Assignees

@HaJunRyu HaJunRyu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HaJunRyu @Baek2back