Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.2.0 배포 #244

Merged
merged 4 commits into from
Apr 5, 2023
Merged

Release v1.2.0 배포 #244

merged 4 commits into from
Apr 5, 2023

Conversation

HaJunRyu
Copy link
Member

@HaJunRyu HaJunRyu commented Apr 2, 2023

변경사항

  • 모집 아님을 알리는 mashong 이미지의 placeholder 이미지 추가
  • Modal 오픈시 초기 포커스를 Modal Elelemt가 아닌 내부 Element중 focusable한 속성을 가진 첫번째 요소가 되게끔 수정

작업 유형

  • 리팩토링

체크리스트

  • Merge 할 브랜치가 올바른가?
  • 코딩컨벤션을 준수하였는가?
  • 해당 PR과 관련없는 변경사항이 없는가? (만약 있다면 제목이나 변경사항에 기술하여 주세요.)
  • 실행시 console 창에 에러나 경고가 없는것을 확인하였는가? (개발에 필요하여 고의적으로 남겨둔것 제외)

Sorry, something went wrong.

HaJunRyu and others added 4 commits April 1, 2023 16:15

Verified

This commit was signed with the committer’s verified signature.
luixxiul Suguru Hirahara
…t-period

초기 렌더링시 노출되는 mashong 이미지의 placeholder 설정
Modal오픈시 초기 포커스를 Modal 내부 focusable의 첫번째 요소로 변경
@HaJunRyu HaJunRyu requested a review from Baek2back as a code owner April 2, 2023 13:48
@HaJunRyu HaJunRyu self-assigned this Apr 2, 2023
Copy link
Member

@Baek2back Baek2back left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@HaJunRyu HaJunRyu merged commit 4f3a1ae into main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants